Source/web/WebViewImpl.cpp - Issue 19096009: Use isHTMLTextAreaElement and toHTMLTextAreaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 19096009: Use isHTMLTextAreaElement and toHTMLTextAreaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 0c3cdacbb191ecba5e1a35bf4977e967b4446e40..17153a38f5e181a8d896a47d8e7e2f0dfdae9780 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -2288,8 +2288,8 @@ WebTextInputType WebViewImpl::textInputType()

return WebTextInputTypeNone;

}

- if (node->hasTagName(HTMLNames::textareaTag)) {

- if (static_cast<HTMLTextAreaElement*>(node)->isDisabledOrReadOnly())

+ if (isHTMLTextAreaElement(node)) {

+ if (toHTMLTextAreaElement(node)->isDisabledOrReadOnly())

return WebTextInputTypeNone;

return WebTextInputTypeTextArea;

}

« no previous file with comments | « Source/web/WebSearchableFormData.cpp ('k') | no next file » | no next file with comments »