Source/web/WebSearchableFormData.cpp - Issue 19096009: Use isHTMLTextAreaElement and toHTMLTextAreaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebSearchableFormData.cpp

Issue 19096009: Use isHTMLTextAreaElement and toHTMLTextAreaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebSearchableFormData.cpp

diff --git a/Source/web/WebSearchableFormData.cpp b/Source/web/WebSearchableFormData.cpp

index 7d65a41fee571ef5c24228790808707e5a2f8576..b24489bc77929719365121c8d5b22462213eee18 100644

--- a/Source/web/WebSearchableFormData.cpp

+++ b/Source/web/WebSearchableFormData.cpp

@@ -42,6 +42,7 @@

#include "core/html/HTMLOptionElement.h"

#include "core/html/HTMLOptionsCollection.h"

#include "core/html/HTMLSelectElement.h"

+#include "core/html/HTMLTextAreaElement.h"

#include "core/loader/DocumentLoader.h"

#include "core/page/Frame.h"

#include "core/platform/network/FormDataBuilder.h"

@@ -166,7 +167,7 @@ HTMLInputElement* findSuitableSearchInputElement(const HTMLFormElement* form)

if (control->isDisabledFormControl() || control->name().isNull())

continue;

- if (!IsInDefaultState(control) || control->hasTagName(HTMLNames::textareaTag))

+ if (!IsInDefaultState(control) || isHTMLTextAreaElement(control))

return 0;

if (control->hasTagName(HTMLNames::inputTag) && control->willValidate()) {

« no previous file with comments | « Source/web/WebFrameImpl.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »