Source/web/WebFrameImpl.cpp - Issue 19096009: Use isHTMLTextAreaElement and toHTMLTextAreaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebFrameImpl.cpp

Issue 19096009: Use isHTMLTextAreaElement and toHTMLTextAreaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebFrameImpl.cpp

diff --git a/Source/web/WebFrameImpl.cpp b/Source/web/WebFrameImpl.cpp

index 365cfb2109d813f2570e7dfa491e9ed071f3bd6c..f5e8689b56b47922817dbb0f72dc501113a8041a 100644

--- a/Source/web/WebFrameImpl.cpp

+++ b/Source/web/WebFrameImpl.cpp

@@ -133,6 +133,7 @@

#include "core/html/HTMLHeadElement.h"

#include "core/html/HTMLInputElement.h"

#include "core/html/HTMLLinkElement.h"

+#include "core/html/HTMLTextAreaElement.h"

#include "core/html/PluginDocument.h"

#include "core/inspector/InspectorController.h"

#include "core/inspector/ScriptCallStack.h"

@@ -2292,7 +2293,7 @@ void WebFrameImpl::setFindEndstateFocusAndSelection()

Node* node = m_activeMatch->firstNode();

if (node && node->isInShadowTree()) {

Node* host = node->deprecatedShadowAncestorNode();

- if (host->hasTagName(HTMLNames::inputTag) || host->hasTagName(HTMLNames::textareaTag))

+ if (host->hasTagName(HTMLNames::inputTag) || isHTMLTextAreaElement(host))

node = host;

}

for (; node; node = node->parentNode()) {

« no previous file with comments | « Source/core/testing/Internals.cpp ('k') | Source/web/WebSearchableFormData.cpp » ('j') | no next file with comments »