Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: tools/rebaseline_imagefiles.py

Issue 19096007: rebaseline.py: until we fix bug 1410, keep going if we can't download an actual GM result (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 ''' 3 '''
4 Copyright 2013 Google Inc. 4 Copyright 2013 Google Inc.
5 5
6 Use of this source code is governed by a BSD-style license that can be 6 Use of this source code is governed by a BSD-style license that can be
7 found in the LICENSE file. 7 found in the LICENSE file.
8 ''' 8 '''
9 9
10 ''' 10 '''
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 if self._tests: 271 if self._tests:
272 if test not in self._tests: 272 if test not in self._tests:
273 skipped_files.append(filename) 273 skipped_files.append(filename)
274 continue 274 continue
275 if self._configs: 275 if self._configs:
276 if config not in self._configs: 276 if config not in self._configs:
277 skipped_files.append(filename) 277 skipped_files.append(filename)
278 continue 278 continue
279 outfilename = os.path.join(self._expectations_root, subdir, 279 outfilename = os.path.join(self._expectations_root, subdir,
280 filename); 280 filename);
281 self._RebaselineOneFile(expectations_subdir=subdir, 281 # TODO(epoger): Until we resolve
282 builder_name=builder, 282 # https://code.google.com/p/skia/issues/detail?id=1410 ('some GM
283 infilename=filename, 283 # result images not available for download from Google Storage'),
284 outfilename=outfilename, 284 # keep going in the face of missing results for any one test.
285 all_results=all_results) 285 try:
286 self._RebaselineOneFile(expectations_subdir=subdir,
287 builder_name=builder,
288 infilename=filename,
289 outfilename=outfilename,
290 all_results=all_results)
291 except Exception as e:
292 print 'WARNING: swallowing exception %s' % e
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698