Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 190953009: Use new is*Element() helper functions in page/ code (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
adamk, eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Use new is*Element() helper functions in page/ code Use new is*Element() helpers in page/ code. This makes the code clearer and simpler. R=eseidel, adamk BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -32 lines) Patch
M Source/core/page/Chrome.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/DragController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/FocusController.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/PageSerializer.cpp View 5 chunks +10 lines, -11 lines 0 comments Download
M Source/core/page/SpatialNavigation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/SpatialNavigation.cpp View 3 chunks +7 lines, -8 lines 0 comments Download
M Source/core/page/TouchDisambiguation.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Inactive
6 years, 9 months ago (2014-03-10 18:15:09 UTC) #1
Inactive
ping review
6 years, 9 months ago (2014-03-12 13:11:24 UTC) #2
adamk
lgtm
6 years, 9 months ago (2014-03-12 18:39:04 UTC) #3
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-12 18:59:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/190953009/1
6 years, 9 months ago (2014-03-12 19:31:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 20:35:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_blink_rel
6 years, 9 months ago (2014-03-12 20:35:08 UTC) #7
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-12 20:40:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/190953009/1
6 years, 9 months ago (2014-03-12 20:40:33 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 21:24:31 UTC) #10
Message was sent while issue was closed.
Change committed as 169058

Powered by Google App Engine
This is Rietveld 408576698