Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 190953008: reorg iteration code in rrects GM, tightly pack rrects drawn in _effect version. (Closed)

Created:
6 years, 9 months ago by bsalomon
Modified:
6 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

reorg iteration code in rrects GM, tightly pack rrects drawn in _effect version. Committed: http://code.google.com/p/skia/source/detail?r=13728

Patch Set 1 #

Patch Set 2 : add to ignored_tests.txt #

Patch Set 3 : fix build warning #

Patch Set 4 : fix new error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -20 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +4 lines, -1 line 0 comments Download
M gm/rrects.cpp View 1 2 3 5 chunks +35 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
bsalomon
I'm going to add some more test cases to this set of GMs. There are ...
6 years, 9 months ago (2014-03-10 15:15:06 UTC) #1
robertphillips
lgtm
6 years, 9 months ago (2014-03-10 16:05:23 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-10 16:07:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/190953008/20001
6 years, 9 months ago (2014-03-10 16:14:21 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-10 16:34:54 UTC) #5
commit-bot: I haz the power
Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for step(s) BuildGm http://108.170.219.164:10117/buildstatus?builder=Build-Mac10.8-Clang-x86-Release-Trybot&number=232
6 years, 9 months ago (2014-03-10 16:34:55 UTC) #6
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-10 18:23:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/190953008/30001
6 years, 9 months ago (2014-03-10 18:23:59 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-10 18:30:34 UTC) #9
commit-bot: I haz the power
Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for step(s) BuildGm http://108.170.219.164:10117/buildstatus?builder=Build-Mac10.8-Clang-x86-Release-Trybot&number=236
6 years, 9 months ago (2014-03-10 18:30:34 UTC) #10
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-10 18:52:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/190953008/50001
6 years, 9 months ago (2014-03-10 18:52:12 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 19:33:19 UTC) #13
Message was sent while issue was closed. 
Change committed as 13728

Powered by Google App Engine
This is Rietveld 408576698