Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: trunk/src/content/renderer/render_view_impl.cc

Issue 190953007: Revert 255928 "Only notify V8 once per timezone change" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/content/renderer/render_view_impl.cc
===================================================================
--- trunk/src/content/renderer/render_view_impl.cc (revision 255938)
+++ trunk/src/content/renderer/render_view_impl.cc (working copy)
@@ -379,8 +379,13 @@
}
// static
-void RenderViewImpl::NotifyTimezoneChange() {
+void RenderViewImpl::NotifyTimezoneChange(blink::WebFrame* frame) {
+ v8::HandleScope handle_scope(v8::Isolate::GetCurrent());
+ v8::Context::Scope context_scope(frame->mainWorldScriptContext());
v8::Date::DateTimeConfigurationChangeNotification(v8::Isolate::GetCurrent());
+ blink::WebFrame* child = frame->firstChild();
+ for (; child; child = child->nextSibling())
+ NotifyTimezoneChange(child);
}
// static
@@ -3773,7 +3778,8 @@
}
void RenderViewImpl::OnUpdateTimezone() {
- NotifyTimezoneChange();
+ if (webview())
+ NotifyTimezoneChange(webview()->mainFrame());
}
void RenderViewImpl::OnEnumerateDirectoryResponse(
« no previous file with comments | « trunk/src/content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698