Source/modules/webaudio/AudioBufferSourceNode.h - Issue 190953005: Support nullable buffer for AudioBufferSourceNode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AudioBufferSourceNode.h

Issue 190953005: Support nullable buffer for AudioBufferSourceNode. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/webaudio/audiobuffersource-channels-expected.txt ('k') | Source/modules/webaudio/AudioBufferSourceNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/AudioBufferSourceNode.h

diff --git a/Source/modules/webaudio/AudioBufferSourceNode.h b/Source/modules/webaudio/AudioBufferSourceNode.h

index 05d2db905ccb52f95ad44f7402bd349393a9c07e..df4928b93b7de3f25ede13fb732c6a03701a51fb 100644

--- a/Source/modules/webaudio/AudioBufferSourceNode.h

+++ b/Source/modules/webaudio/AudioBufferSourceNode.h

@@ -106,6 +106,9 @@ private:

// m_buffer holds the sample data which this node outputs.

RefPtr<AudioBuffer> m_buffer;

+ // Used for setBuffer() called with null.

+ RefPtr<AudioBuffer> m_nullableBuffer;

// Pointers for the buffer and destination.

OwnPtr<const float*[]> m_sourceChannels;

OwnPtr<float*[]> m_destinationChannels;

« no previous file with comments | « LayoutTests/webaudio/audiobuffersource-channels-expected.txt ('k') | Source/modules/webaudio/AudioBufferSourceNode.cpp » ('j') | no next file with comments »