Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1909523002: Roll buildtools 5378d73123..e84114dbe2 (Closed)

Created:
4 years, 8 months ago by brettw
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools 5378d73123..e84114dbe2 In order to roll GN e55108830c..b17c5d23f1 (r387371:r388502) and pick up the following changes: fb8986d GN: Make write_runtime_deps take effect only a target is resolved e4b98e2 Fix GN freeze on generating Visual Studio projects 440b117 Add arflags to GN 3150001 GN: Use std::unique_ptr for owned pointers in VisualStudioWriter. 959ec4e GN: Use std::unique_ptr for owning pointers in InputFileManager. f9b6b5a GN: Use std::unique_ptr in Loader::ToolchainRecordMap. ac5bf2c GN: Use std::unique_ptr for owning pointers in Scope::NamedScopeMap. 647a1af GN: Use std::unique_ptr for owned pointers in ImportManager. 6ce99c7 GN: Replace vector<ParseNode*> with vector<unique_ptr<ParseNode>> in parse_tree.h. c065bd8 gn: Use .obj extension for pch objects on Windows. 8ea3910 [MIPS] Fix gn_unittests LoaderTest.Foo test a67a258 Make it easy to run `gn format' on an emacs buffer. 3a93fa5 Add shell=True for gn-format.py on Windows TBR=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel Committed: https://crrev.com/caf58db6354bfce41b3b3ea1db7213f554087634 Cr-Commit-Position: refs/heads/master@{#388529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
4 years, 8 months ago (2016-04-20 15:44:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909523002/1
4 years, 8 months ago (2016-04-20 15:44:39 UTC) #3
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-20 16:40:19 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/191050)
4 years, 8 months ago (2016-04-20 17:29:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909523002/1
4 years, 8 months ago (2016-04-20 17:37:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 17:45:32 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:24:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/caf58db6354bfce41b3b3ea1db7213f554087634
Cr-Commit-Position: refs/heads/master@{#388529}

Powered by Google App Engine
This is Rietveld 408576698