Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1909513002: [wasm] Extra LEB utilities to leb-helper.h (Closed)

Created:
4 years, 8 months ago by titzer
Modified:
4 years, 8 months ago
Reviewers:
bradnelson, aseemgarg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Extra LEB utilities to leb-helper.h R=bradnelson@chromium.org,aseemgarg@chromium.org BUG= Committed: https://crrev.com/727c7df035521e6cb2a58b10d25c4fc416cf1350 Cr-Commit-Position: refs/heads/master@{#35695}

Patch Set 1 #

Patch Set 2 : Add unittests for signed encodings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -143 lines) Patch
M BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M src/wasm/asm-wasm-builder.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M src/wasm/ast-decoder.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/wasm/ast-decoder.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/wasm/encoder.h View 2 chunks +1 line, -1 line 0 comments Download
M src/wasm/encoder.cc View 13 chunks +44 lines, -61 lines 0 comments Download
A src/wasm/leb-helper.h View 1 1 chunk +131 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/wasm/encoder-unittest.cc View 2 chunks +1 line, -56 lines 0 comments Download
A test/unittests/wasm/leb-helper-unittest.cc View 1 1 chunk +190 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
titzer
4 years, 8 months ago (2016-04-20 14:59:05 UTC) #1
aseemgarg
lgtm
4 years, 8 months ago (2016-04-20 17:42:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909513002/20001
4 years, 8 months ago (2016-04-21 09:47:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/16751)
4 years, 8 months ago (2016-04-21 09:58:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909513002/20001
4 years, 8 months ago (2016-04-21 10:00:44 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 10:14:39 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:26 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/727c7df035521e6cb2a58b10d25c4fc416cf1350
Cr-Commit-Position: refs/heads/master@{#35695}

Powered by Google App Engine
This is Rietveld 408576698