Refactor ExternalNavigationHandlerTest to be easier to parse.

Refactor ExternalNavigationHandlerTest to be easier to parse.

The let's add more params approach makes the test very hard to
read, so this pulls out a params/builder-ish method that hopefully
clears this up (for people other than just me).

BUG=

Committed: https://crrev.com/f7287905100545d98fec1dcbea66204ed66831d4
Cr-Commit-Position: refs/heads/master@{#388562}

[Ted C, 2016-04-20 18:42:25]

tedchoc@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[Ted C, 2016-04-20 18:42:26]

PTAL

[Maria, 2016-04-20 18:51:52]

lgtm

I can't find words to express how much I like this change. Thank you!

[Ted C, 2016-04-20 19:02:24]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2016-04-20 19:02:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/1909503003/#ps2 (title:
"Don't set user gesture until the next patch")

[commit-bot: I haz the power, 2016-04-20 19:02:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909503003/2
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909503003/2

[commit-bot: I haz the power, 2016-04-20 20:07:35]

Committed patchset #3 (id:2)

[commit-bot: I haz the power, 2016-04-22 19:25:53]

Description was changed from

==========
Refactor ExternalNavigationHandlerTest to be easier to parse.

The let's add more params approach makes the test very hard to
read, so this pulls out a params/builder-ish method that hopefully
clears this up (for people other than just me).

BUG=
==========

to

==========
Refactor ExternalNavigationHandlerTest to be easier to parse.

The let's add more params approach makes the test very hard to
read, so this pulls out a params/builder-ish method that hopefully
clears this up (for people other than just me).

BUG=

Committed: https://crrev.com/f7287905100545d98fec1dcbea66204ed66831d4
Cr-Commit-Position: refs/heads/master@{#388562}
==========

[commit-bot: I haz the power, 2016-04-22 19:25:54]

Patchset 3 (id:??) landed as
https://crrev.com/f7287905100545d98fec1dcbea66204ed66831d4
Cr-Commit-Position: refs/heads/master@{#388562}