Throw 'SecurityError' upon cross-origin Location access.

Source/bindings/v8/V8Initializer.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 17 matching lines @@
 
 #include "V8History.h"
 #include "V8Location.h"
 #include "V8Window.h"
 #include "bindings/v8/ScriptCallStackFactory.h"
 #include "bindings/v8/ScriptProfiler.h"
 #include "bindings/v8/V8Binding.h"
 #include "bindings/v8/V8GCController.h"
 #include "bindings/v8/V8PerContextData.h"
 #include "core/dom/Document.h"
+#include "core/dom/ExceptionCode.h"
 #include "core/inspector/ScriptCallStack.h"
 #include "core/page/ConsoleTypes.h"
 #include "core/page/ContentSecurityPolicy.h"
 #include "core/page/DOMWindow.h"
 #include "core/page/Frame.h"
 #include "core/platform/MemoryUsageSupport.h"
 #include <v8-debug.h>
 #include "wtf/RefPtr.h"
 #include "wtf/text/WTFString.h"
 
@@ skipping 48 matching lines @@
     firstWindow->document()->reportException(errorMessage, message->GetLineNumber(), resource, callStack);
 }
 
 static void failedAccessCheckCallbackInMainThread(v8::Local<v8::Object> host, v8::AccessType type, v8::Local<v8::Value> data)
 {
     Frame* target = findFrame(host, data, v8::Isolate::GetCurrent());
     if (!target)
         return;
     DOMWindow* targetWindow = target->document()->domWindow();
     targetWindow->printErrorMessage(targetWindow->crossDomainAccessErrorMessage(activeDOMWindow()));
+
+    // Throw an exception for failed-access checks against Location objects, otherwise write to the console.
+    WrapperTypeInfo* typeInfo = WrapperTypeInfo::unwrap(data);
+    if (V8Location::info.equals(typeInfo))
+        setDOMException(SecurityError, v8::Isolate::GetCurrent());

[abarth-chromium, 2013/07/12 22:57:08]

Why only location?  Why not have every security violation throw an exception?  I
guess we can start with location and see how it goes.

 }
 
 static bool codeGenerationCheckCallbackInMainThread(v8::Local<v8::Context> context)
 {
     if (ScriptExecutionContext* scriptExecutionContext = toScriptExecutionContext(context)) {
         if (ContentSecurityPolicy* policy = toDocument(scriptExecutionContext)->contentSecurityPolicy())
             return policy->allowEval(ScriptState::forContext(context));
     }
     return false;
 }
@@ skipping 63 matching lines @@
 
     v8::ResourceConstraints resourceConstraints;
     uint32_t here;
     resourceConstraints.set_stack_limit(&here - kWorkerMaxStackSize / sizeof(uint32_t*));
     v8::SetResourceConstraints(&resourceConstraints);
 
     V8PerIsolateData::ensureInitialized(isolate);
 }
 
 } // namespace WebCore