chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java - Issue 1909483003: [MediaNotification] Add UMA to record user clicking media notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

Issue 1909483003: [MediaNotification] Add UMA to record user clicking media notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Dan's comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

index 643cc79de0fc1bbd4aa44d8815e1195de3e30266..746bd5d50f54c8b81b2a6f35639e4066d5a17103 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

@@ -553,8 +553,10 @@ public class MediaNotificationManager {

// TODO(avayvod) work out what we should do in this case. See https://crbug.com/585395.

if (mMediaNotificationInfo.contentIntent != null) {

mNotificationBuilder.setContentIntent(PendingIntent.getActivity(mContext,

- mMediaNotificationInfo.tabId,

- mMediaNotificationInfo.contentIntent, 0));

+ mMediaNotificationInfo.tabId, mMediaNotificationInfo.contentIntent,

+ PendingIntent.FLAG_UPDATE_CURRENT));

+ // Set FLAG_UPDATE_CURRENT so that the intent extras is updated, otherwise the

+ // intent extras will stay the same for the same tab.

}

mNotificationBuilder.setVisibility(