Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 1909483003: [MediaNotification] Add UMA to record user clicking media notifications (Closed)

Created:
4 years, 8 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 8 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MediaNotification] Add UMA to record user clicking media notifications This CL adds UMA to record how often the user clicks media notifications to go back to Chrome. BUG=605156 Committed: https://crrev.com/6126ee74cd5a98a55b6a1d3991fb0018ca425136 Cr-Commit-Position: refs/heads/master@{#389090}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : renaming #

Total comments: 26

Patch Set 4 : addressed comments #

Total comments: 8

Patch Set 5 : addressed Dan's comments #

Total comments: 4

Patch Set 6 : renaming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java View 1 2 3 4 4 chunks +6 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 1 2 3 4 5 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java View 1 2 3 4 4 chunks +7 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/metrics/LaunchMetrics.java View 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/metrics/MediaNotificationUma.java View 1 2 3 4 5 1 chunk +40 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (10 generated)
Zhiqiang Zhang (Slow)
PTAL +dfalcantara to look at: ChromeLauncherActivity.java .../chrome/browser/metrics/*.java java_sources.gni +mlamouri/avayvod to look at: .../chrome/browser/media/*
4 years, 8 months ago (2016-04-20 17:20:32 UTC) #3
gone
https://chromiumcodereview.appspot.com/1909483003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java File chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java (right): https://chromiumcodereview.appspot.com/1909483003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java#newcode103 chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java:103: Intent contentIntent = new Intent(mContext, ExpandedControllerActivity.class) Don't do this ...
4 years, 8 months ago (2016-04-20 22:17:14 UTC) #4
Zhiqiang Zhang (Slow)
https://codereview.chromium.org/1909483003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java (right): https://codereview.chromium.org/1909483003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java#newcode558 chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:558: // intent extras will stay the same for the ...
4 years, 8 months ago (2016-04-21 10:36:47 UTC) #5
Zhiqiang Zhang (Slow)
https://codereview.chromium.org/1909483003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java (right): https://codereview.chromium.org/1909483003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java#newcode558 chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:558: // intent extras will stay the same for the ...
4 years, 8 months ago (2016-04-21 10:37:54 UTC) #7
mlamouri (slow - plz ping)
Couple of comments see below. Otherwise, you might want to use `git cl format` to ...
4 years, 8 months ago (2016-04-21 12:37:26 UTC) #8
Zhiqiang Zhang (Slow)
On 2016/04/21 12:37:26, Mounir Lamouri wrote: > Couple of comments see below. Otherwise, you might ...
4 years, 8 months ago (2016-04-21 16:36:08 UTC) #9
Zhiqiang Zhang (Slow)
PTAL. Addressed reviewer's comments with replies. https://codereview.chromium.org/1909483003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java File chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java (right): https://codereview.chromium.org/1909483003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java#newcode103 chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java:103: Intent contentIntent = ...
4 years, 8 months ago (2016-04-21 16:36:53 UTC) #11
Zhiqiang Zhang (Slow)
PTAL. Addressed reviewer's comments with replies.
4 years, 8 months ago (2016-04-21 16:36:54 UTC) #13
Zhiqiang Zhang (Slow)
+isherman@ to look at histograms.xml
4 years, 8 months ago (2016-04-21 16:39:31 UTC) #15
gone
Yeah, never use git cl format on Java files. It just ruins everything. lgtm https://codereview.chromium.org/1909483003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java ...
4 years, 8 months ago (2016-04-21 17:16:35 UTC) #16
Ilya Sherman
histograms lgtm
4 years, 8 months ago (2016-04-22 08:19:06 UTC) #17
Zhiqiang Zhang (Slow)
Addressed dan's comments. Need approval from avayvod/mlamouri. https://codereview.chromium.org/1909483003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java File chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java (right): https://codereview.chromium.org/1909483003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java#newcode104 chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java:104: .putExtra(MediaNotificationUma.INTENT_EXTRA_NAME, On ...
4 years, 8 months ago (2016-04-22 10:14:34 UTC) #18
mlamouri (slow - plz ping)
lgtm Sorry for the wrong tip with regards to `git cl format` :( https://codereview.chromium.org/1909483003/diff/80001/tools/metrics/histograms/histograms.xml File ...
4 years, 8 months ago (2016-04-22 10:32:50 UTC) #19
Zhiqiang Zhang (Slow)
https://codereview.chromium.org/1909483003/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1909483003/diff/80001/tools/metrics/histograms/histograms.xml#newcode20974 tools/metrics/histograms/histograms.xml:20974: +<histogram name="Media.Notification.ClickSource" On 2016/04/22 10:32:50, Mounir Lamouri wrote: > ...
4 years, 8 months ago (2016-04-22 12:41:47 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909483003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909483003/100001
4 years, 8 months ago (2016-04-22 12:42:03 UTC) #23
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 8 months ago (2016-04-22 13:51:05 UTC) #25
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:46:50 UTC) #27
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/6126ee74cd5a98a55b6a1d3991fb0018ca425136
Cr-Commit-Position: refs/heads/master@{#389090}

Powered by Google App Engine
This is Rietveld 408576698