Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Issue 1909453004: [Mac][Material Design] Adjust EV chip to match Material Design spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nits. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
index 621ee6e2275182c6d0281f69b4cb90629d4a8b6c..d82e4b675ef266b88a1f40269d924c7f2e701eb4 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
@@ -159,13 +159,18 @@ NSColor* OmniboxViewMac::SuggestTextColor() {
return [NSColor colorWithCalibratedWhite:0.0 alpha:0.5];
}
+//static
+SkColor OmniboxViewMac::BaseTextColorSkia(bool in_dark_mode) {
+ return in_dark_mode ? SkColorSetA(SK_ColorWHITE, 0x7F)
+ : SkColorSetA(SK_ColorBLACK, 0x7F);
+}
+
// static
-NSColor* OmniboxViewMac::BaseTextColor(bool inDarkMode) {
+NSColor* OmniboxViewMac::BaseTextColor(bool in_dark_mode) {
if (!ui::MaterialDesignController::IsModeMaterial()) {
return [NSColor darkGrayColor];
}
- return inDarkMode ? [NSColor colorWithCalibratedWhite:1 alpha:0.5]
- : [NSColor colorWithCalibratedWhite:0 alpha:0.5];
+ return skia::SkColorToCalibratedNSColor(BaseTextColorSkia(in_dark_mode));
}
OmniboxViewMac::OmniboxViewMac(OmniboxEditController* controller,
« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698