chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h - Issue 1909453004: [Mac][Material Design] Adjust EV chip to match Material Design spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

Issue 1909453004: [Mac][Material Design] Adjust EV chip to match Material Design spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix problems. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm ('K') | « chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm ('k') | chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm » ('j') | chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

index 91897e5a023dce5941e2c601144c637eaed7ecbd..a9a99163b6671dfcd559de88b130b49f77ee2718 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

@@ -31,7 +31,8 @@ class Clipboard;

class OmniboxViewMac : public OmniboxView,

public AutocompleteTextFieldObserver {

public:

- static NSColor* BaseTextColor(bool inDarkMode);

+ static SkColor SkBaseTextColor(bool in_dark_mode);

tapted 2016/04/27 02:37:39 I read `Sk` prefixes as belonging to stuff declare

shrike 2016/04/27 16:35:17 Done.

+ static NSColor* BaseTextColor(bool in_dark_mode);

OmniboxViewMac(OmniboxEditController* controller,

Profile* profile,