[Mac][Material Design] Adjust EV chip to match Material Design spec.

chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
+#import "base/mac/mac_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #import "chrome/browser/app_controller_mac.h"
 #include "chrome/browser/command_updater.h"
 #include "chrome/browser/defaults.h"
 #include "chrome/browser/extensions/api/omnibox/omnibox_api.h"
@@ skipping 57 matching lines @@
 #include "ui/gfx/vector_icons_public.h"
 
 using content::WebContents;
 
 namespace {
 
 // Vertical space between the bottom edge of the location_bar and the first run
 // bubble arrow point.
 const static int kFirstRunBubbleYOffset = 1;
 
+const int kDefaultIconSize = 16;
+const int kMaterialSmallIconSize = 12;
+
 }  // namespace
 
 // TODO(shess): This code is mostly copied from the gtk
 // implementation.  Make sure it's all appropriate and flesh it out.
 
 LocationBarViewMac::LocationBarViewMac(AutocompleteTextField* field,
                                        CommandUpdater* command_updater,
                                        Profile* profile,
                                        Browser* browser)
     : LocationBar(profile),
@@ skipping 100 matching lines @@
   WebContents* web_contents = GetWebContents();
   if (!web_contents)
     return;
 
   // |controller| may be nullptr due to lazy initialization.
   autofill::SaveCardBubbleControllerImpl* controller =
       autofill::SaveCardBubbleControllerImpl::FromWebContents(web_contents);
   bool enabled = controller && controller->IsIconVisible();
   command_updater()->UpdateCommandEnabled(IDC_SAVE_CREDIT_CARD_FOR_PAGE,
                                           enabled);
-  bool inDarkMode = [[field_ window] inIncognitoModeWithSystemTheme];
-  save_credit_card_decoration_->SetIcon(inDarkMode);
+  bool in_dark_mode = [[field_ window] inIncognitoModeWithSystemTheme];
+  save_credit_card_decoration_->SetIcon(in_dark_mode);
   save_credit_card_decoration_->SetVisible(enabled);
   OnDecorationsChanged();
 }
 
 void LocationBarViewMac::UpdatePageActions() {
   RefreshPageActionDecorations();
   Layout();
 
   [field_ updateMouseTracking];
   [field_ setNeedsDisplay:YES];
@@ skipping 122 matching lines @@
   if (star_decoration_->starred() == starred)
     return;
 
   star_decoration_->SetStarred(starred,
       [[field_ window] inIncognitoModeWithSystemTheme]);
   UpdateBookmarkStarVisibility();
   OnDecorationsChanged();
 }
 
 void LocationBarViewMac::SetTranslateIconLit(bool on) {
-  bool inDarkMode = [[field_ window] inIncognitoModeWithSystemTheme];
-  translate_decoration_->SetLit(on, inDarkMode);
+  bool in_dark_mode = [[field_ window] inIncognitoModeWithSystemTheme];
+  translate_decoration_->SetLit(on, in_dark_mode);
   OnDecorationsChanged();
 }
 
 void LocationBarViewMac::ZoomChangedForActiveTab(bool can_show_bubble) {
   bool changed = UpdateZoomDecoration(/*default_zoom_changed=*/false);
   if (changed)
     OnDecorationsChanged();
 
   if (can_show_bubble && zoom_decoration_->IsVisible())
     zoom_decoration_->ShowBubble(YES);
@@ skipping 186 matching lines @@
   else
     omnibox_view_->Update();
   OnChanged();
 }
 
 void LocationBarViewMac::UpdateWithoutTabRestore() {
   Update(nullptr);
 }
 
 void LocationBarViewMac::UpdateLocationIcon() {
-  bool inDarkMode = [[field_ window] inIncognitoModeWithSystemTheme];
+  bool in_dark_mode = [[field_ window] inIncognitoModeWithSystemTheme];
 
-  SkColor vectorIconColor = gfx::kPlaceholderColor;
-  gfx::VectorIconId vectorIconId = gfx::VectorIconId::VECTOR_ICON_NONE;
-  const int kIconSize = 16;
+  SkColor vector_icon_color = gfx::kPlaceholderColor;
+  gfx::VectorIconId vector_icon_id = gfx::VectorIconId::VECTOR_ICON_NONE;
+  int icon_size = kDefaultIconSize;
   if (ShouldShowEVBubble()) {
-    vectorIconId = gfx::VectorIconId::LOCATION_BAR_HTTPS_VALID_IN_CHIP;
-    vectorIconColor = gfx::kGoogleGreen700;
+    vector_icon_id = gfx::VectorIconId::LOCATION_BAR_HTTPS_VALID_IN_CHIP;
+    vector_icon_color = gfx::kGoogleGreen700;
+    icon_size = kMaterialSmallIconSize;
   } else {
-    vectorIconId = omnibox_view_->GetVectorIcon(inDarkMode);
-    if (inDarkMode) {
-      vectorIconColor = SK_ColorWHITE;
+    vector_icon_id = omnibox_view_->GetVectorIcon(in_dark_mode);
+    if (in_dark_mode) {
+      vector_icon_color = SK_ColorWHITE;
     } else {
-      NSColor* textColor = OmniboxViewMac::BaseTextColor(inDarkMode);
-      // Convert to the device color space before getting the SkColor.
-      textColor = [textColor colorUsingColorSpaceName:NSDeviceRGBColorSpace];
-      vectorIconColor = skia::NSDeviceColorToSkColor(textColor);
+      vector_icon_color = OmniboxViewMac::BaseTextColorSkia(in_dark_mode);
     }
   }
 
-  DCHECK(vectorIconId != gfx::VectorIconId::VECTOR_ICON_NONE);
-  NSImage* image = NSImageFromImageSkia(gfx::CreateVectorIcon(
-      vectorIconId, kIconSize, vectorIconColor));
+  DCHECK(vector_icon_id != gfx::VectorIconId::VECTOR_ICON_NONE);
+  NSImage* image = NSImageFromImageSkiaWithColorSpace(
+      gfx::CreateVectorIcon(vector_icon_id, icon_size, vector_icon_color),
+      base::mac::GetSRGBColorSpace());
 
   location_icon_decoration_->SetImage(image);
   ev_bubble_decoration_->SetImage(image);
-
   Layout();
 }
 
 void LocationBarViewMac::UpdateColorsToMatchTheme() {
   if (!ui::MaterialDesignController::IsModeMaterial() ||
       ![[field_ window] inIncognitoMode]) {
     return;
   }
 
   // Update the location-bar icon.
   UpdateLocationIcon();
 
   // Make sure we're displaying the correct star color for Incognito mode. If
   // the window is in Incognito mode, switching between a theme and no theme
   // can move the window in and out of dark mode.
-  bool inDarkMode = [[field_ window] inIncognitoModeWithSystemTheme];
-  star_decoration_->SetStarred(star_decoration_->starred(), inDarkMode);
+  bool in_dark_mode = [[field_ window] inIncognitoModeWithSystemTheme];
+  star_decoration_->SetStarred(star_decoration_->starred(), in_dark_mode);
 
   // Update the appearance of the text in the Omnibox.
   omnibox_view_->Update();
 }
 
 void LocationBarViewMac::OnAddedToWindow() {
   UpdateColorsToMatchTheme();
 }
 
 void LocationBarViewMac::OnThemeChanged() {
@@ skipping 42 matching lines @@
 NSImage* LocationBarViewMac::GetKeywordImage(const base::string16& keyword) {
   const TemplateURL* template_url = TemplateURLServiceFactory::GetForProfile(
       profile())->GetTemplateURLForKeyword(keyword);
   if (template_url &&
       (template_url->GetType() == TemplateURL::OMNIBOX_API_EXTENSION)) {
     return extensions::OmniboxAPI::Get(profile())->
         GetOmniboxIcon(template_url->GetExtensionId()).AsNSImage();
   }
 
   return ui::MaterialDesignController::IsModeMaterial()
-      ? NSImageFromImageSkia(gfx::CreateVectorIcon(
-          gfx::VectorIconId::OMNIBOX_SEARCH, 16, gfx::kGoogleBlue700))
+      ? NSImageFromImageSkiaWithColorSpace(
+            gfx::CreateVectorIcon(
+                gfx::VectorIconId::OMNIBOX_SEARCH,
+                kDefaultIconSize,
+                gfx::kGoogleBlue700),
+            base::mac::GetSRGBColorSpace())
       : OmniboxViewMac::ImageForResource(IDR_OMNIBOX_SEARCH);
 }
 
 void LocationBarViewMac::PostNotification(NSString* notification) {
   [[NSNotificationCenter defaultCenter] postNotificationName:notification
                                         object:[NSValue valueWithPointer:this]];
 }
 
 PageActionDecoration* LocationBarViewMac::GetPageActionDecoration(
     ExtensionAction* page_action) {
@@ skipping 103 matching lines @@
     return;
 
   WebContents* web_contents = GetWebContents();
   if (!web_contents)
     return;
   translate::LanguageState& language_state =
       ChromeTranslateClient::FromWebContents(web_contents)->GetLanguageState();
   bool enabled = language_state.translate_enabled();
   command_updater()->UpdateCommandEnabled(IDC_TRANSLATE_PAGE, enabled);
   translate_decoration_->SetVisible(enabled);
-  bool inDarkMode = [[field_ window] inIncognitoModeWithSystemTheme];
-  translate_decoration_->SetLit(language_state.IsPageTranslated(), inDarkMode);
+  bool in_dark_mode = [[field_ window] inIncognitoModeWithSystemTheme];
+  translate_decoration_->SetLit(language_state.IsPageTranslated(),
+                                in_dark_mode);
 }
 
 bool LocationBarViewMac::UpdateZoomDecoration(bool default_zoom_changed) {
   WebContents* web_contents = GetWebContents();
   if (!web_contents)
     return false;
 
-  bool inDarkMode = [[field_ window] inIncognitoModeWithSystemTheme];
+  bool in_dark_mode = [[field_ window] inIncognitoModeWithSystemTheme];
   return zoom_decoration_->UpdateIfNecessary(
       ui_zoom::ZoomController::FromWebContents(web_contents),
       default_zoom_changed,
-      inDarkMode);
+      in_dark_mode);
 }
 
 void LocationBarViewMac::OnDefaultZoomLevelChanged() {
   if (UpdateZoomDecoration(/*default_zoom_changed=*/true))
     OnDecorationsChanged();
 }