[Mac][Material Design] Adjust EV chip to match Material Design spec.

chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h"
 
 #include <Carbon/Carbon.h>  // kVK_Return
 
 #include "base/mac/foundation_util.h"
 #include "base/memory/ptr_util.h"
@@ skipping 141 matching lines @@
 NSImage* OmniboxViewMac::ImageForResource(int resource_id) {
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   return rb.GetNativeImageNamed(resource_id).ToNSImage();
 }
 
 // static
 NSColor* OmniboxViewMac::SuggestTextColor() {
   return [NSColor colorWithCalibratedWhite:0.0 alpha:0.5];
 }
 
+//static
+SkColor OmniboxViewMac::SkBaseTextColor(bool in_dark_mode) {
+  // The returned colors should match BaseTextColor.
+  const SkColor kFiftyPercentWhite = 0x7FFFFFFF;
+  const SkColor kFiftyPercentBlack = 0x7F000000;
+  return in_dark_mode ? kFiftyPercentWhite

[tapted, 2016/04/27 02:37:39]

what you have is fine, an alternative if you like it could be

return in_dark_mode ? SkColorSetA(SK_ColorWHITE, 127)
    : SkColorSetA(SK_ColorBLACK, 127);

This avoids the assumption that SkColor is ARGB, but that's unlikely to change,
and I don't really like those 127s either

[shrike, 2016/04/27 16:35:17]

I like your suggestion better (with 0x7F instead of 127).

+                      : kFiftyPercentBlack;
+}
+
 // static
-NSColor* OmniboxViewMac::BaseTextColor(bool inDarkMode) {
+NSColor* OmniboxViewMac::BaseTextColor(bool in_dark_mode) {
   if (!ui::MaterialDesignController::IsModeMaterial()) {
     return [NSColor darkGrayColor];
   }
-  return inDarkMode ? [NSColor colorWithCalibratedWhite:1 alpha:0.5]
-                    : [NSColor colorWithCalibratedWhite:0 alpha:0.5];
+  return skia::SkColorToCalibratedNSColor(SkBaseTextColor(in_dark_mode));
 }
 
 OmniboxViewMac::OmniboxViewMac(OmniboxEditController* controller,
                                Profile* profile,
                                CommandUpdater* command_updater,
                                AutocompleteTextField* field)
     : OmniboxView(
           controller,
           base::WrapUnique(new ChromeOmniboxClient(controller, profile))),
       profile_(profile),
@@ skipping 929 matching lines @@
 
 NSUInteger OmniboxViewMac::GetTextLength() const {
   return [field_ currentEditor] ?  [[[field_ currentEditor] string] length] :
                                    [[field_ stringValue] length];
 }
 
 bool OmniboxViewMac::IsCaretAtEnd() const {
   const NSRange selection = GetSelectedRange();
   return NSMaxRange(selection) == GetTextLength();
 }