Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1909443002: Extend the "Clear data" button translation limit to 30 chars. (Closed)

Created:
4 years, 8 months ago by msramek
Modified:
4 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extend the "Clear data" button translation limit to 30 chars. The previous 20 chars was unnecessarily short, since the button has its own row on the screen, and was reported not to be enough for e.g. Georgian translation. TBR=tedchoc@chromium.org BUG=605097 Committed: https://crrev.com/0415dd81282d858c0b886556ece36a6e020a192e Cr-Commit-Position: refs/heads/master@{#388478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
msramek
Hi Ted, please have a look! This is b/27393751 that you routed to me. Thanks, ...
4 years, 8 months ago (2016-04-20 12:10:01 UTC) #2
msramek
Actually, let me straight away TBR and land this, since you already approved this change ...
4 years, 8 months ago (2016-04-20 12:12:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909443002/1
4 years, 8 months ago (2016-04-20 12:12:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 12:53:55 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:22:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0415dd81282d858c0b886556ece36a6e020a192e
Cr-Commit-Position: refs/heads/master@{#388478}

Powered by Google App Engine
This is Rietveld 408576698