Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: src/ic/mips/ic-mips.cc

Issue 1909433003: Remove support for Object.observe (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ic.cc ('k') | src/ic/mips64/ic-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 598 matching lines...) Expand 10 before | Expand all | Expand 10 after
609 Register elements_map = t2; 609 Register elements_map = t2;
610 Register elements = t3; // Elements array of the receiver. 610 Register elements = t3; // Elements array of the receiver.
611 // t0 and t1 are used as general scratch registers. 611 // t0 and t1 are used as general scratch registers.
612 612
613 // Check that the key is a smi. 613 // Check that the key is a smi.
614 __ JumpIfNotSmi(key, &maybe_name_key); 614 __ JumpIfNotSmi(key, &maybe_name_key);
615 // Check that the object isn't a smi. 615 // Check that the object isn't a smi.
616 __ JumpIfSmi(receiver, &slow); 616 __ JumpIfSmi(receiver, &slow);
617 // Get the map of the object. 617 // Get the map of the object.
618 __ lw(receiver_map, FieldMemOperand(receiver, HeapObject::kMapOffset)); 618 __ lw(receiver_map, FieldMemOperand(receiver, HeapObject::kMapOffset));
619 // Check that the receiver does not require access checks and is not observed. 619 // Check that the receiver does not require access checks.
620 // The generic stub does not perform map checks or handle observed objects. 620 // The generic stub does not perform map checks.
621 __ lbu(t0, FieldMemOperand(receiver_map, Map::kBitFieldOffset)); 621 __ lbu(t0, FieldMemOperand(receiver_map, Map::kBitFieldOffset));
622 __ And(t0, t0, 622 __ And(t0, t0, Operand(1 << Map::kIsAccessCheckNeeded));
623 Operand(1 << Map::kIsAccessCheckNeeded | 1 << Map::kIsObserved));
624 __ Branch(&slow, ne, t0, Operand(zero_reg)); 623 __ Branch(&slow, ne, t0, Operand(zero_reg));
625 // Check if the object is a JS array or not. 624 // Check if the object is a JS array or not.
626 __ lbu(t0, FieldMemOperand(receiver_map, Map::kInstanceTypeOffset)); 625 __ lbu(t0, FieldMemOperand(receiver_map, Map::kInstanceTypeOffset));
627 __ Branch(&array, eq, t0, Operand(JS_ARRAY_TYPE)); 626 __ Branch(&array, eq, t0, Operand(JS_ARRAY_TYPE));
628 // Check that the object is some kind of JS object EXCEPT JS Value type. In 627 // Check that the object is some kind of JS object EXCEPT JS Value type. In
629 // the case that the object is a value-wrapper object, we enter the runtime 628 // the case that the object is a value-wrapper object, we enter the runtime
630 // system to make sure that indexing into string objects works as intended. 629 // system to make sure that indexing into string objects works as intended.
631 STATIC_ASSERT(JS_VALUE_TYPE < JS_OBJECT_TYPE); 630 STATIC_ASSERT(JS_VALUE_TYPE < JS_OBJECT_TYPE);
632 __ Branch(&slow, lo, t0, Operand(JS_OBJECT_TYPE)); 631 __ Branch(&slow, lo, t0, Operand(JS_OBJECT_TYPE));
633 632
(...skipping 268 matching lines...) Expand 10 before | Expand all | Expand 10 after
902 break; 901 break;
903 default: 902 default:
904 UNIMPLEMENTED(); 903 UNIMPLEMENTED();
905 } 904 }
906 patcher.ChangeBranchCondition(branch_instr, opcode); 905 patcher.ChangeBranchCondition(branch_instr, opcode);
907 } 906 }
908 } // namespace internal 907 } // namespace internal
909 } // namespace v8 908 } // namespace v8
910 909
911 #endif // V8_TARGET_ARCH_MIPS 910 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ic/ic.cc ('k') | src/ic/mips64/ic-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698