Issue 190943003: Mojo: MultiprocessTestBase -> MultiprocessTestHelper.

Issue 190943003: Mojo: MultiprocessTestBase -> MultiprocessTestHelper. (Closed)

Created:
6 years, 9 months ago by viettrungluu

Modified:
6 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: MultiprocessTestBase -> MultiprocessTestHelper. Because inheritance sucks. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255798

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -403 lines)			Patch
D	mojo/common/test/multiprocess_test_base.h	View		1 chunk	+0 lines, -76 lines	0 comments	Download
D	mojo/common/test/multiprocess_test_base.cc	View		1 chunk	+0 lines, -108 lines	0 comments	Download
D	mojo/common/test/multiprocess_test_base_unittest.cc	View		1 chunk	+0 lines, -135 lines	0 comments	Download
A +	mojo/common/test/multiprocess_test_helper.h	View		4 chunks	+11 lines, -16 lines	0 comments	Download
A +	mojo/common/test/multiprocess_test_helper.cc	View		4 chunks	+12 lines, -39 lines	0 comments	Download
A +	mojo/common/test/multiprocess_test_helper_unittest.cc	View		3 chunks	+21 lines, -17 lines	0 comments	Download
M	mojo/mojo.gyp	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	mojo/system/multiprocess_message_pipe_unittest.cc	View		8 chunks	+15 lines, -9 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

I guess I should have mentioned that this is dependent on https://codereview.chromium.org/189373002/.

6 years, 9 months ago (2014-03-07 19:07:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/190943003/20001

6 years, 9 months ago (2014-03-08 21:02:33 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-08 22:23:09 UTC) #6

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234584

6 years, 9 months ago (2014-03-08 22:23:09 UTC) #7

viettrungluu

6 years, 9 months ago (2014-03-08 22:58:41 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 manually as r255798 (presubmit successful).

Expand Messages | Collapse Messages