chrome/browser/resources/settings/site_settings/site_settings_category.js - Issue 1909413002: Site Settings: Implement dialog for adding site exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_settings_category.js

Issue 1909413002: Site Settings: Implement dialog for adding site exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_settings_category.html ('k') | chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_settings_category.js

diff --git a/chrome/browser/resources/settings/site_settings/site_settings_category.js b/chrome/browser/resources/settings/site_settings/site_settings_category.js

index fe3a19cae7e35dc30f8726f262042eee3241215a..6bf06cfceae3c81fd2fc39f04c044f68b2fb19a7 100644

--- a/chrome/browser/resources/settings/site_settings/site_settings_category.js

+++ b/chrome/browser/resources/settings/site_settings/site_settings_category.js

@@ -112,4 +112,20 @@ Polymer({

this.categoryEnabled = enabled;

}.bind(this));

+ /**

+ * A handler for the Add Site button.

+ * @private

+ */

+ onAddSiteTap_: function() {

+ var dialog = document.createElement('add-site-dialog');

+ dialog.category = this.category;

+ this.shadowRoot.appendChild(dialog);

+ dialog.open();

+ dialog.addEventListener('iron-overlay-closed', function() {

+ dialog.remove();

+ });

+ },

});