 Chromium Code Reviews
 Chromium Code Reviews Issue 1909413002:
  Site Settings: Implement dialog for adding site exceptions.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1909413002:
  Site Settings: Implement dialog for adding site exceptions.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js | 
| diff --git a/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js b/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js | 
| index 45f6bc6a7023e8e91ba73a5795f18a182a51971c..6b58ec4b6aad8535660d27fa3b3383b8a4efde56 100644 | 
| --- a/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js | 
| +++ b/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js | 
| @@ -82,6 +82,13 @@ cr.define('settings', function() { | 
| */ | 
| setCategoryPermissionForOrigin: function( | 
| primaryPattern, secondaryPattern, contentType, value) {}, | 
| + | 
| + /** | 
| + * Checks whether a pattern is valid. | 
| + * @param {string} pattern The pattern to check | 
| + * @return {Promise<boolean>} True if the pattern is valid. | 
| 
michaelpg
2016/04/24 19:58:40
nit: !Promise
 
Finnur
2016/04/25 10:23:13
Done.
 | 
| + */ | 
| + isPatternValid: function(pattern) {}, | 
| }; | 
| /** | 
| @@ -123,6 +130,12 @@ cr.define('settings', function() { | 
| chrome.send('setCategoryPermissionForOrigin', | 
| [primaryPattern, secondaryPattern, contentType, value]); | 
| }, | 
| + | 
| + /** @override */ | 
| + isPatternValid: function(pattern) { | 
| + return cr.sendWithPromise('isPatternValid', pattern); | 
| + }, | 
| + | 
| }; | 
| return { |