chrome/browser/resources/settings/site_settings/add_site_dialog.html - Issue 1909413002: Site Settings: Implement dialog for adding site exceptions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/site_settings/add_site_dialog.html

Issue 1909413002: Site Settings: Implement dialog for adding site exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sync to head Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_resources.grd ('k') | chrome/browser/resources/settings/site_settings/add_site_dialog.js » ('j') | chrome/browser/resources/settings/site_settings/add_site_dialog.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">

	4 <link rel="import" href="chrome://md-settings/i18n_setup.html">

	5 <link rel="import" href="chrome://md-settings/settings_dialog.html">

	6 <link rel="import" href="chrome://md-settings/settings_shared_css.html">

	7

	8 <dom-module id="add-site-dialog">

	9 <template>

	10 <style include="settings-shared"></style>

	11 <settings-dialog id="dialog">

	12 <div class="title" i18n-content="addSiteHeader"></div>
	michaelpg 2016/04/24 19:58:39 since this is new code, could you use $i18n{} inst since this is new code, could you use $i18n{} instead of i18n-foo? Finnur 2016/04/25 10:23:12 Done. Show quoted text On 2016/04/24 19:58:39, michaelpg wrote: > since this is new code, could you use $i18n{} instead of i18n-foo? Done.
	13 <div class="body">

	14 <span class="start" i18n-content="addSite"></span>

	15 <paper-input type="text" id="site" autofocus

	16 value="{{site_}}" on-input="validate_"></paper-input>

	17 </div>

	18 <div class="button-container">

	19 <paper-button class="cancel-button" i18n-content="cancel"

	20 dialog-dismiss></paper-button>

	21 <paper-button class="action-button" id="add"

	22 i18n-content="add" on-tap="onAddTap_" disabled>

	23 </paper-button>

	24 </div>

	25 </settings-dialog>

	26 </template>

	27 <script src="add_site_dialog.js"></script>

	28 </dom-module>

OLD	NEW