Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: src/frames.h

Issue 1909353002: [wasm] Make wasm info available on the stack trace (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@wasm-offset-table-3
Patch Set: more gcmole problems Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/frames.h
diff --git a/src/frames.h b/src/frames.h
index ed02c6e62496031912b39adf5ccbfbf9f9a66fa9..f8b5dbe1e4235db0f582f387ae09bd2064c8719f 100644
--- a/src/frames.h
+++ b/src/frames.h
@@ -641,11 +641,11 @@ class FrameSummary BASE_EMBEDDED {
static FrameSummary GetFirst(JavaScriptFrame* frame);
- Handle<Object> receiver() { return receiver_; }
- Handle<JSFunction> function() { return function_; }
- Handle<AbstractCode> abstract_code() { return abstract_code_; }
- int code_offset() { return code_offset_; }
- bool is_constructor() { return is_constructor_; }
+ Handle<Object> receiver() const { return receiver_; }
titzer 2016/04/22 12:16:25 AFAICT FrameSummary instances are already immutabl
Clemens Hammacher 2016/04/26 14:00:10 Removed the const.
+ Handle<JSFunction> function() const { return function_; }
+ Handle<AbstractCode> abstract_code() const { return abstract_code_; }
+ int code_offset() const { return code_offset_; }
+ bool is_constructor() const { return is_constructor_; }
void Print();
@@ -677,13 +677,6 @@ class StandardFrame : public StackFrame {
return static_cast<StandardFrame*>(frame);
}
- // Build a list with summaries for this frame including all inlined frames.
- virtual void Summarize(List<FrameSummary>* frames) const;
-
- // Accessors.
- virtual JSFunction* function() const;
- virtual Object* receiver() const;
-
protected:
inline explicit StandardFrame(StackFrameIteratorBase* iterator);
@@ -728,8 +721,12 @@ class JavaScriptFrame : public StandardFrame {
public:
Type type() const override { return JAVA_SCRIPT; }
- JSFunction* function() const override;
- Object* receiver() const override;
+ // Build a list with summaries for this frame including all inlined frames.
+ virtual void Summarize(List<FrameSummary>* frames) const;
+
+ // Accessors.
+ virtual JSFunction* function() const;
+ virtual Object* receiver() const;
inline void set_receiver(Object* value);
@@ -777,8 +774,6 @@ class JavaScriptFrame : public StandardFrame {
// Return a list with JSFunctions of this frame.
virtual void GetFunctions(List<JSFunction*>* functions) const;
- void Summarize(List<FrameSummary>* frames) const override;
-
// Lookup exception handler for current {pc}, returns -1 if none found. Also
// returns data associated with the handler site specific to the frame type:
// - JavaScriptFrame : Data is the stack depth at entry of the try-block.
@@ -960,15 +955,16 @@ class WasmFrame : public StandardFrame {
// Determine the code for the frame.
Code* unchecked_code() const override;
+ Object* wasm_obj(Handle<Code> code = Handle<Code>());
+ uint32_t function_index(Handle<Code> code = Handle<Code>());
+
+ Object* function_name(Handle<Code> code = Handle<Code>());
+
static WasmFrame* cast(StackFrame* frame) {
DCHECK(frame->is_wasm());
return static_cast<WasmFrame*>(frame);
}
- JSFunction* function() const override;
-
- void Summarize(List<FrameSummary>* frames) const override;
-
protected:
inline explicit WasmFrame(StackFrameIteratorBase* iterator);

Powered by Google App Engine
This is Rietveld 408576698