Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: src/frames.h

Issue 1909353002: [wasm] Make wasm info available on the stack trace (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@wasm-offset-table-3
Patch Set: last changes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/wasm-compiler.cc ('k') | src/frames.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.h
diff --git a/src/frames.h b/src/frames.h
index b2eec8bf0046b816f9d3115f865dc5089b85a553..4163d6f82e379dd3efe256c23d4a378f110fbe78 100644
--- a/src/frames.h
+++ b/src/frames.h
@@ -635,8 +635,8 @@ class JavaScriptFrame;
class FrameSummary BASE_EMBEDDED {
public:
- // Mode for StandardFrame::Summarize. Exact summary is required to produce an
- // exact stack trace. It will trigger an assertion failure if that is not
+ // Mode for JavaScriptFrame::Summarize. Exact summary is required to produce
+ // an exact stack trace. It will trigger an assertion failure if that is not
// possible, e.g., because of missing deoptimization information. The
// approximate mode should produce a summary even without deoptimization
// information, but it might miss frames.
@@ -684,15 +684,6 @@ class StandardFrame : public StackFrame {
return static_cast<StandardFrame*>(frame);
}
- // Build a list with summaries for this frame including all inlined frames.
- virtual void Summarize(
- List<FrameSummary>* frames,
- FrameSummary::Mode mode = FrameSummary::kExactSummary) const;
-
- // Accessors.
- virtual JSFunction* function() const;
- virtual Object* receiver() const;
-
protected:
inline explicit StandardFrame(StackFrameIteratorBase* iterator);
@@ -737,8 +728,14 @@ class JavaScriptFrame : public StandardFrame {
public:
Type type() const override { return JAVA_SCRIPT; }
- JSFunction* function() const override;
- Object* receiver() const override;
+ // Build a list with summaries for this frame including all inlined frames.
+ virtual void Summarize(
+ List<FrameSummary>* frames,
+ FrameSummary::Mode mode = FrameSummary::kExactSummary) const;
+
+ // Accessors.
+ virtual JSFunction* function() const;
+ virtual Object* receiver() const;
inline void set_receiver(Object* value);
@@ -786,10 +783,6 @@ class JavaScriptFrame : public StandardFrame {
// Return a list with JSFunctions of this frame.
virtual void GetFunctions(List<JSFunction*>* functions) const;
- void Summarize(
- List<FrameSummary>* frames,
- FrameSummary::Mode mode = FrameSummary::kExactSummary) const override;
-
// Lookup exception handler for current {pc}, returns -1 if none found. Also
// returns data associated with the handler site specific to the frame type:
// - JavaScriptFrame : Data is the stack depth at entry of the try-block.
@@ -975,17 +968,16 @@ class WasmFrame : public StandardFrame {
// Determine the code for the frame.
Code* unchecked_code() const override;
+ Object* wasm_obj();
+ uint32_t function_index();
+
+ Object* function_name();
+
static WasmFrame* cast(StackFrame* frame) {
DCHECK(frame->is_wasm());
return static_cast<WasmFrame*>(frame);
}
- JSFunction* function() const override;
-
- void Summarize(
- List<FrameSummary>* frames,
- FrameSummary::Mode mode = FrameSummary::kExactSummary) const override;
-
protected:
inline explicit WasmFrame(StackFrameIteratorBase* iterator);
« no previous file with comments | « src/compiler/wasm-compiler.cc ('k') | src/frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698