[wasm] Make wasm info available on the stack trace

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/api.h"
 
 #include <string.h>  // For memcpy, strlen.
 #ifdef V8_USE_ADDRESS_SANITIZER
 #include <sanitizer/asan_interface.h>
 #endif  // V8_USE_ADDRESS_SANITIZER
@@ skipping 2550 matching lines @@
   options = static_cast<StackTraceOptions>(
       static_cast<int>(options) | kExposeFramesAcrossSecurityOrigins);
   i::Handle<i::JSArray> stackTrace =
       i_isolate->CaptureCurrentStackTrace(frame_limit, options);
   return Utils::StackTraceToLocal(stackTrace);
 }
 
 
 // --- S t a c k F r a m e ---
 
+#define STACKFRAME_PROPERTY_HELPER(obj, propertyName, MAKE_SCOPE) \

[titzer, 2016/04/22 12:16:25]

As tempting as this is, let's not macro-ify this code. The macros aren't
hygenic, and we'd be doing it only in these few places. So we hold our noses and
do what the surrounding code does.

[Clemens Hammacher, 2016/04/26 14:00:10]

Hm, OK.

+  i::Isolate* isolate = Utils::OpenHandle(f)->GetIsolate();       \
+  ENTER_V8(isolate);                                              \
+  MAKE_SCOPE(scope, isolate);                                     \
+  i::Handle<i::JSObject> self = Utils::OpenHandle(f);             \
+  i::Handle<i::Object> obj =                                      \
+      i::JSReceiver::GetProperty(isolate, self, propertyName)     \
+          .ToHandleChecked();
+#define MAKE_STD_SCOPE(name, isolate) i::HandleScope name(isolate)
+#define STACKFRAME_PROPERTY(obj, propertyName) \
+  STACKFRAME_PROPERTY_HELPER(obj, propertyName, MAKE_STD_SCOPE)
+#define MAKE_ESCAPABLE_SCOPE(name, isolate) \
+  EscapableHandleScope name(reinterpret_cast<Isolate*>(isolate))
+#define STACKFRAME_ESCAPABLE_PROPERTY(obj, propertyName) \
+  STACKFRAME_PROPERTY_HELPER(obj, propertyName, MAKE_ESCAPABLE_SCOPE)
+
 static int getIntProperty(const StackFrame* f, const char* propertyName,
                           int defaultValue) {
-  i::Isolate* isolate = Utils::OpenHandle(f)->GetIsolate();
-  ENTER_V8(isolate);
-  i::HandleScope scope(isolate);
-  i::Handle<i::JSObject> self = Utils::OpenHandle(f);
-  i::Handle<i::Object> obj =
-      i::JSReceiver::GetProperty(isolate, self, propertyName).ToHandleChecked();
+  STACKFRAME_PROPERTY(obj, propertyName)
   return obj->IsSmi() ? i::Smi::cast(*obj)->value() : defaultValue;
 }
 
+static uint32_t getUintProperty(const StackFrame* f, const char* propertyName,
+                                uint32_t defaultValue) {
+  STACKFRAME_PROPERTY(obj, propertyName)
+  uint32_t val = defaultValue;
+  obj->ToUint32(&val);
+  return val;
+}
+
+static Local<String> getStringProperty(const StackFrame* f,
+                                       const char* propertyName) {
+  STACKFRAME_ESCAPABLE_PROPERTY(obj, propertyName)
+  return obj->IsString()
+             ? scope.Escape(Local<String>::Cast(Utils::ToLocal(obj)))
+             : Local<String>();
+}
+
+static Local<Object> getObjectProperty(const StackFrame* f,
+                                       const char* propertyName) {
+  STACKFRAME_ESCAPABLE_PROPERTY(obj, propertyName);
+  return obj->IsObject()
+             ? scope.Escape(Local<Object>::Cast(Utils::ToLocal(obj)))
+             : Local<Object>();
+}
+
+static bool getBoolProperty(const StackFrame* f, const char* propertyName) {
+  STACKFRAME_PROPERTY(obj, propertyName);
+  return obj->IsTrue();
+}
 
 int StackFrame::GetLineNumber() const {
   return getIntProperty(this, "lineNumber", Message::kNoLineNumberInfo);
 }
 
 
 int StackFrame::GetColumn() const {
   return getIntProperty(this, "column", Message::kNoColumnInfo);
 }
 
 
 int StackFrame::GetScriptId() const {
   return getIntProperty(this, "scriptId", Message::kNoScriptIdInfo);
 }
 
-
-static Local<String> getStringProperty(const StackFrame* f,
-                                       const char* propertyName) {
-  i::Isolate* isolate = Utils::OpenHandle(f)->GetIsolate();
-  ENTER_V8(isolate);
-  EscapableHandleScope scope(reinterpret_cast<Isolate*>(isolate));
-  i::Handle<i::JSObject> self = Utils::OpenHandle(f);
-  i::Handle<i::Object> obj =
-      i::JSReceiver::GetProperty(isolate, self, propertyName).ToHandleChecked();
-  return obj->IsString()
-             ? scope.Escape(Local<String>::Cast(Utils::ToLocal(obj)))
-             : Local<String>();
-}
-
-
 Local<String> StackFrame::GetScriptName() const {
   return getStringProperty(this, "scriptName");
 }
 
 
 Local<String> StackFrame::GetScriptNameOrSourceURL() const {
   return getStringProperty(this, "scriptNameOrSourceURL");
 }
 
 
 Local<String> StackFrame::GetFunctionName() const {
   return getStringProperty(this, "functionName");
 }
 
-
-static bool getBoolProperty(const StackFrame* f, const char* propertyName) {
-  i::Isolate* isolate = Utils::OpenHandle(f)->GetIsolate();
-  ENTER_V8(isolate);
-  i::HandleScope scope(isolate);
-  i::Handle<i::JSObject> self = Utils::OpenHandle(f);
-  i::Handle<i::Object> obj =
-      i::JSReceiver::GetProperty(isolate, self, propertyName).ToHandleChecked();
-  return obj->IsTrue();
-}
-
 bool StackFrame::IsEval() const { return getBoolProperty(this, "isEval"); }
 
 
 bool StackFrame::IsConstructor() const {
   return getBoolProperty(this, "isConstructor");
 }
 
+bool StackFrame::IsWasm() const { return getBoolProperty(this, "isWasm"); }
+
+Local<Object> StackFrame::GetWasmObject() const {
+  return getObjectProperty(this, "wasmObject");
+}
+
+uint32_t StackFrame::GetWasmByteOffset() const {
+  return getUintProperty(this, "wasmByteOffset",
+                         Message::kNoWasmByteOffsetInfo);
+}
 
 // --- N a t i v e W e a k M a p ---
 
 Local<NativeWeakMap> NativeWeakMap::New(Isolate* v8_isolate) {
   i::Isolate* isolate = reinterpret_cast<i::Isolate*>(v8_isolate);
   ENTER_V8(isolate);
   i::Handle<i::JSWeakMap> weakmap = isolate->factory()->NewJSWeakMap();
   i::JSWeakCollection::Initialize(weakmap, isolate);
   return Utils::NativeWeakMapToLocal(weakmap);
 }
@@ skipping 6180 matching lines @@
   Address callback_address =
       reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
   VMState<EXTERNAL> state(isolate);
   ExternalCallbackScope call_scope(isolate, callback_address);
   callback(info);
 }
 
 
 }  // namespace internal
 }  // namespace v8