[wasm] Make wasm info available on the stack trace

src/compiler/wasm-compiler.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/wasm-compiler.h"
 
 #include "src/isolate-inl.h"
 
 #include "src/base/platform/elapsed-timer.h"
 #include "src/base/platform/platform.h"
@@ skipping 3033 matching lines @@
       compile_timer.Start();
     }
     Handle<Code> code = info_.code();
     DCHECK(!code.is_null());
     DCHECK(code->deoptimization_data() == nullptr ||
            code->deoptimization_data()->length() == 0);
     Handle<FixedArray> deopt_data =
         isolate_->factory()->NewFixedArray(2, TENURED);
     if (!module_env_->instance->js_object.is_null()) {
       deopt_data->set(0, *module_env_->instance->js_object);
-      deopt_data->set(1, Smi::FromInt(function_->func_index));
-    } else if (info_.GetDebugName().get() != nullptr) {
-      MaybeHandle<String> maybe_name = isolate_->factory()->NewStringFromUtf8(
-          CStrVector(info_.GetDebugName().get()));
+    } else {
+      base::SmartArrayPointer<char> debug_name = info_.GetDebugName();
+      MaybeHandle<String> maybe_name;
+      if (debug_name.get() != nullptr)
+        maybe_name = isolate_->factory()->NewStringFromUtf8(

[Yang, 2016/05/03 18:59:07]

Can we have brackets around if-body here and below?

[Clemens Hammacher, 2016/05/04 09:06:19]

It turned out the first if is even redundant, so I removed it. But I added
brackets around the one below.

+            CStrVector(debug_name.get()));
       if (!maybe_name.is_null())
         deopt_data->set(0, *maybe_name.ToHandleChecked());
     }
+    deopt_data->set(1, Smi::FromInt(function_->func_index));
     deopt_data->set_length(2);
     code->set_deoptimization_data(*deopt_data);
 
     RecordFunctionCompilation(
         Logger::FUNCTION_TAG, &info_, "WASM_function", function_->func_index,
         module_env_->module->GetName(function_->name_offset,
                                      function_->name_length));
 
     if (FLAG_trace_wasm_decode_time) {
       double compile_ms = compile_timer.Elapsed().InMillisecondsF();
@@ skipping 43 matching lines @@
                                  const wasm::WasmFunction* function) {
   WasmCompilationUnit* unit =
       CreateWasmCompilationUnit(thrower, isolate, module_env, function, 0);
   ExecuteCompilation(unit);
   return FinishCompilation(unit);
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8