[wasm] Make wasm info available on the stack trace

test/cctest/wasm/test-wasm-stack.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/wasm/wasm-macro-gen.h"
 
 #include "test/cctest/cctest.h"
 #include "test/cctest/compiler/value-helper.h"
 #include "test/cctest/wasm/test-signatures.h"
 #include "test/cctest/wasm/wasm-run-utils.h"
 
 using namespace v8::base;
 using namespace v8::internal;
 using namespace v8::internal::compiler;
 using namespace v8::internal::wasm;
 
 using v8::Local;
 using v8::Utils;
 
 namespace {
 
 #define CHECK_CSTREQ(exp, found)                                           \
   do {                                                                     \
     const char* exp_ = (exp);                                              \
     const char* found_ = (found);                                          \
-    if (V8_UNLIKELY(strcmp(exp_, found_) != 0)) {                          \
+    DCHECK_NOT_NULL(exp);                                                  \
+    if (V8_UNLIKELY(found_ == nullptr || strcmp(exp_, found_) != 0)) {     \
       V8_Fatal(__FILE__, __LINE__,                                         \
                "Check failed: (%s) != (%s) ('%s' vs '%s').", #exp, #found, \
-               exp_, found_);                                              \
+               exp_, found_ ? found_ : "<null>");                          \
     }                                                                      \
   } while (0)
 
 void PrintStackTrace(v8::Local<v8::StackTrace> stack) {
   printf("Stack Trace (length %d):\n", stack->GetFrameCount());
   for (int i = 0, e = stack->GetFrameCount(); i != e; ++i) {
     v8::Local<v8::StackFrame> frame = stack->GetFrame(i);
-    v8::Local<v8::String> script = frame->GetScriptName();
     v8::Local<v8::String> func = frame->GetFunctionName();
-    printf("[%d] (%s) %s:%d:%d\n", i,
-           script.IsEmpty() ? "<null>" : *v8::String::Utf8Value(script),
-           func.IsEmpty() ? "<null>" : *v8::String::Utf8Value(func),
-           frame->GetLineNumber(), frame->GetColumn());
+    if (frame->IsWasm()) {
+      printf("[%d] (<WASM>) %s:%d\n", i,
+             func.IsEmpty() ? "<null>" : *v8::String::Utf8Value(func),
+             frame->GetWasmByteOffset());
+    } else {
+      v8::Local<v8::String> script = frame->GetScriptName();
+      printf("[%d] (%s) %s:%d:%d\n", i,
+             script.IsEmpty() ? "<null>" : *v8::String::Utf8Value(script),
+             func.IsEmpty() ? "<null>" : *v8::String::Utf8Value(func),
+             frame->GetLineNumber(), frame->GetColumn());
+    }
   }
 }
 
 struct ExceptionInfo {
   const char* funcName;
   int lineNr;
 };
 
 template <int N>
 void CheckExceptionInfos(Isolate* isolate, Handle<Object> exc,
@@ skipping 48 matching lines @@
                                                      v8::StackTrace::kOverview);
   Handle<Object> global(isolate->context()->global_object(), isolate);
   MaybeHandle<Object> maybe_exc;
   Handle<Object> args[] = {js_wasm_wrapper};
   MaybeHandle<Object> returnObjMaybe =
       Execution::TryCall(isolate, js_trampoline, global, 1, args, &maybe_exc);
   CHECK(returnObjMaybe.is_null());
 
   // Line number is 1-based, with 0 == kNoLineNumberInfo.
   ExceptionInfo expected_exceptions[] = {
-      {"a", 3},       // Comment to prevent clang-format complaints
-      {"js", 4},      // -
-      {"<WASM>", 0},  // -
-      {"<WASM>", 0},  // -
+      {"a", 3},               // Prevent clang-format changes.
+      {"js", 4},              // -
+      {"<WASM UNNAMED>", 0},  // -
+      {"<WASM UNNAMED>", 0},  // -
       {"callFn", 1}};
   CheckExceptionInfos(isolate, maybe_exc.ToHandleChecked(),
                       expected_exceptions);
 }
 
 // Trigger a trap in WASM, stack should be JS -> WASM -> WASM.
 TEST(CollectDetailedWasmStack_WasmError) {
   TestSignatures sigs;
   TestingModule module;
 
@@ skipping 20 matching lines @@
                                                      v8::StackTrace::kOverview);
   Handle<Object> global(isolate->context()->global_object(), isolate);
   MaybeHandle<Object> maybe_exc;
   Handle<Object> args[] = {js_wasm_wrapper};
   MaybeHandle<Object> maybe_return_obj =
       Execution::TryCall(isolate, js_trampoline, global, 1, args, &maybe_exc);
   CHECK(maybe_return_obj.is_null());
 
   // Line number is 1-based, with 0 == kNoLineNumberInfo.
   ExceptionInfo expected_exceptions[] = {
-      {"<WASM>", 0},  // Comment to prevent clang-format complaints.
-      {"<WASM>", 0},
+      {"exec_unreachable", 0},       // Prevent clang-format changes.
+      {"call_exec_unreachable", 0},  // -
       {"callFn", 1}};
   CheckExceptionInfos(isolate, maybe_exc.ToHandleChecked(),
                       expected_exceptions);
 }