TextIteratorAlgorithm should not force layout update in constructor.

TextIteratorAlgorithm should not force layout update in constructor.

This is a third attempt at landing this (which time is the charm? I forget). Yay!

Asking to update layout should not be done at this level -- updating layout is part of the document/view lifecycle and should be coordinated at a higher level than an iterator constructor.

Thus, move calling Document::updateLayoutIgnorePendingStylesheets up to the callsites of the TextIterator constructor. These callsites should be audited and moved up even farther up the call stack.

BUG=590295
R=esprehn,yosin

Committed: https://crrev.com/a3eecad9b893616b8666e11da69d6ea28c85b6bf
Cr-Commit-Position: refs/heads/master@{#389355}

[dglazkov, 2016-04-22 21:05:53]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 21:06:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909343003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909343003/1

[commit-bot: I haz the power, 2016-04-22 22:44:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 22:44:06]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dglazkov, 2016-04-23 00:25:25]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-23 00:25:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909343003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909343003/1

[commit-bot: I haz the power, 2016-04-23 00:30:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-23 00:30:11]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-04-23 02:07:26]

lgtm

[dglazkov, 2016-04-23 03:31:09]

The CQ bit was checked by dglazkov@chromium.org

[commit-bot: I haz the power, 2016-04-23 03:31:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909343003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909343003/1

[commit-bot: I haz the power, 2016-04-23 03:35:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-23 03:37:32]

Description was changed from

==========
TextIteratorAlgorithm should not force layout update in constructor.

This is a third attempt at landing this (which time is the charm? I forget).
Yay!

Asking to update layout should not be done at this level -- updating layout is
part of the document/view lifecycle and should be coordinated at a higher level
than an iterator constructor.

Thus, move calling Document::updateLayoutIgnorePendingStylesheets up to the
callsites of the TextIterator constructor. These callsites should be audited and
moved up even farther up the call stack.

BUG=590295
R=esprehn,yosin
==========

to

==========
TextIteratorAlgorithm should not force layout update in constructor.

This is a third attempt at landing this (which time is the charm? I forget).
Yay!

Asking to update layout should not be done at this level -- updating layout is
part of the document/view lifecycle and should be coordinated at a higher level
than an iterator constructor.

Thus, move calling Document::updateLayoutIgnorePendingStylesheets up to the
callsites of the TextIterator constructor. These callsites should be audited and
moved up even farther up the call stack.

BUG=590295
R=esprehn,yosin

Committed: https://crrev.com/a3eecad9b893616b8666e11da69d6ea28c85b6bf
Cr-Commit-Position: refs/heads/master@{#389355}
==========

[commit-bot: I haz the power, 2016-04-23 03:37:33]

Patchset 1 (id:??) landed as
https://crrev.com/a3eecad9b893616b8666e11da69d6ea28c85b6bf
Cr-Commit-Position: refs/heads/master@{#389355}