Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1909343002: [turbofan] Move more type checks to the representation selector. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move more type checks to the representation selector. Get rid of further typing checks from ChangeLowering and put them into the representation selection pass instead (encoding the information in the operator instead). Drive-by-change: Rename ChangeSmiToInt32 to ChangeTaggedSignedToInt32 for consistency about naming Tagged, TaggedSigned and TaggedPointer. R=jarin@chromium.org Committed: https://crrev.com/550c0f9f55a4da48634481ac3ab8ea486fdbbdff Cr-Commit-Position: refs/heads/master@{#35723}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -81 lines) Patch
M src/compiler/change-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/change-lowering.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/representation-change.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 3 chunks +15 lines, -2 lines 1 comment Download
M src/compiler/simplified-lowering.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +44 lines, -44 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 1 chunk +7 lines, -1 line 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-22 10:31:53 UTC) #1
Benedikt Meurer
Hey Jaro, Next cleanup for representation selection. Please take a look. Thanks, Benedikt
4 years, 8 months ago (2016-04-22 10:33:25 UTC) #2
Jarin
lgtm https://codereview.chromium.org/1909343002/diff/1/src/compiler/representation-change.cc File src/compiler/representation-change.cc (right): https://codereview.chromium.org/1909343002/diff/1/src/compiler/representation-change.cc#newcode327 src/compiler/representation-change.cc:327: std::numeric_limits<double>::quiet_NaN()); Nice! Thanks.
4 years, 8 months ago (2016-04-22 10:35:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909343002/1
4 years, 8 months ago (2016-04-22 10:35:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 11:03:03 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/550c0f9f55a4da48634481ac3ab8ea486fdbbdff
Cr-Commit-Position: refs/heads/master@{#35723}

Powered by Google App Engine
This is Rietveld 408576698