Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1909323003: Revert of Fix interpreter unittest for embedded constant pools. (Closed)

Created:
4 years, 8 months ago by MTBrandyberry
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy, JaideepBajwa
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Fix interpreter unittest for embedded constant pools. (patchset #2 id:20001 of https://codereview.chromium.org/1906963002/ ) Reason for revert: Need to fix the #undef logic. Original issue's description: > Fix interpreter unittest for embedded constant pools. > > The offset from fp to the register file is based on the frame size > -- which is one slot larger when embedded constant pools are enabled. > > TEST=unittests/DecodeBytecodeAndOperands > R=rmcilroy@chromium.org, bmeurer@chromium.org, oth@chromium.org, mstarzinger@chromium.org > BUG= TBR=bmeurer@chromium.org,mstarzinger@chromium.org,oth@chromium.org,rmcilroy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/2a113b8e2eb6aa4db85d9b0e907d6b7d7013c721 Cr-Commit-Position: refs/heads/master@{#35736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -23 lines) Patch
M test/unittests/interpreter/bytecodes-unittest.cc View 4 chunks +6 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
MTBrandyberry
Created Revert of Fix interpreter unittest for embedded constant pools.
4 years, 8 months ago (2016-04-22 15:03:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909323003/1
4 years, 8 months ago (2016-04-22 15:03:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 15:03:46 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:50 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a113b8e2eb6aa4db85d9b0e907d6b7d7013c721
Cr-Commit-Position: refs/heads/master@{#35736}

Powered by Google App Engine
This is Rietveld 408576698