Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3257)

Unified Diff: build/config/android/internal_rules.gni

Issue 1909283002: 🐲 GN(android) Don't run find.py on build/android/ant/empty/res (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/internal_rules.gni
diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
index 61e5f97326d19f0c28474e7c298029b91dfd3db8..3b60f66729ee5d5557e6fa3c065cb75c675911f3 100644
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -1827,11 +1827,16 @@ template("process_resources") {
if (defined(invoker.resource_dirs)) {
_all_resource_dirs += invoker.resource_dirs
- sources_build_rel =
- exec_script("//build/android/gyp/find.py",
- rebase_path(invoker.resource_dirs, root_build_dir),
- "list lines")
- sources += rebase_path(sources_build_rel, ".", root_build_dir)
+
+ # Speed up "gn gen" by short-circuiting the empty directory.
+ if (invoker.resource_dirs != [ "//build/android/ant/empty/res" ] &&
+ invoker.resource_dirs != []) {
+ _sources_build_rel =
+ exec_script("//build/android/gyp/find.py",
+ rebase_path(invoker.resource_dirs, root_build_dir),
+ "list lines")
+ sources += rebase_path(_sources_build_rel, ".", root_build_dir)
+ }
}
if (defined(invoker.generated_resource_dirs)) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698