Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1909283002: 🐲 GN(android) Don't run find.py on build/android/ant/empty/res (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(android) Don't run find.py on build/android/ant/empty/res Shaves ~250ms off of gn gen. BUG=484854 Committed: https://crrev.com/f59c773ff52a2a9c0f4a89f5d309c5dce5542aed Cr-Commit-Position: refs/heads/master@{#389107}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M build/config/android/internal_rules.gni View 1 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909283002/1
4 years, 8 months ago (2016-04-22 01:28:43 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/55160)
4 years, 8 months ago (2016-04-22 01:44:51 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909283002/20001
4 years, 8 months ago (2016-04-22 14:00:04 UTC) #8
agrieve
On 2016/04/22 14:00:04, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 8 months ago (2016-04-22 14:27:11 UTC) #10
Yaron
lgtm
4 years, 8 months ago (2016-04-22 14:32:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909283002/20001
4 years, 8 months ago (2016-04-22 14:33:41 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 15:07:58 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:47:30 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f59c773ff52a2a9c0f4a89f5d309c5dce5542aed
Cr-Commit-Position: refs/heads/master@{#389107}

Powered by Google App Engine
This is Rietveld 408576698