content/renderer/media/pepper_to_video_track_adapter.cc - Issue 1909263002: Replace safe-bool idiom with explicit WeakPtr::operator bool()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/pepper_to_video_track_adapter.cc

Issue 1909263002: Replace safe-bool idiom with explicit WeakPtr::operator bool() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add unit-test for comparison operators Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_provider_host.cc ('k') | device/bluetooth/bluetooth_adapter_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/pepper_to_video_track_adapter.cc

diff --git a/content/renderer/media/pepper_to_video_track_adapter.cc b/content/renderer/media/pepper_to_video_track_adapter.cc

index f1dfa51f6feaeeca77de657e2a23f1613de21db3..afd3b20be0fb1f022923a7091f1ef4621abfb03a 100644

--- a/content/renderer/media/pepper_to_video_track_adapter.cc

+++ b/content/renderer/media/pepper_to_video_track_adapter.cc

@@ -209,7 +209,7 @@ class PpFrameWriterProxy : public FrameWriterInterface {

public:

explicit PpFrameWriterProxy(const base::WeakPtr<PpFrameWriter>& writer)

: writer_(writer) {

- DCHECK(writer_ != NULL);

+ DCHECK(writer_);

}

~PpFrameWriterProxy() override {}

« no previous file with comments | « content/browser/service_worker/service_worker_provider_host.cc ('k') | device/bluetooth/bluetooth_adapter_factory.cc » ('j') | no next file with comments »