Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 190923002: Add deduping capability to SkPathHeap (Closed)

Created:
6 years, 9 months ago by robertphillips
Modified:
6 years, 9 months ago
Reviewers:
bsalomon, mtklein
CC:
skia-review_google.com
Visibility:
Public.

Description

Once Chromium starts holding on to paths and we can actually reuse cached path data (e.g., masks & geometry) we will need a way to preserve that reuse in the skps. This CL begins adding that capability. More analysis & profiling needs to be done before it is always enabled. When enabled it does make the disabled path de-duping test in the Canvas unit test pass. BUG=skia:507 Committed: http://code.google.com/p/skia/source/detail?r=13709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -13 lines) Patch
M src/core/SkPathHeap.h View 2 chunks +26 lines, -0 lines 0 comments Download
M src/core/SkPathHeap.cpp View 2 chunks +33 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/CanvasTest.cpp View 2 chunks +16 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
6 years, 9 months ago (2014-03-07 15:30:02 UTC) #1
robertphillips
Adding Mike K. in case he would like to chime in.
6 years, 9 months ago (2014-03-07 15:30:34 UTC) #2
mtklein
This implementation LGTM. Again, I'd probably have used a hash table here instead of binary ...
6 years, 9 months ago (2014-03-07 17:43:50 UTC) #3
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 9 months ago (2014-03-07 18:11:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/190923002/1
6 years, 9 months ago (2014-03-07 18:11:39 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 18:42:28 UTC) #6
Message was sent while issue was closed.
Change committed as 13709

Powered by Google App Engine
This is Rietveld 408576698