Remove more CFX_ArrayTemplate from fpdf_edit_doc.cpp

Remove more CFX_ArrayTemplate from fpdf_edit_doc.cpp

Committed: https://pdfium.googlesource.com/pdfium/+/00124c928e7513530901a3c7b0a0b928efb9d628

[Tom Sepez, 2016-04-21 22:06:34]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-21 22:06:35]

Lei, for review.

https://codereview.chromium.org/1909213002/diff/60001/core/fpdfapi/fpdf_edit/...
File core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp (left):

https://codereview.chromium.org/1909213002/diff/60001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp:651:
charSets.Add(g_FX_CharsetUnicodes[i].m_Charset);
Note; currently be n^2, checking the old things we know we don't have each time
around.

https://codereview.chromium.org/1909213002/diff/60001/core/fpdfapi/fpdf_edit/...
File core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp (right):

https://codereview.chromium.org/1909213002/diff/60001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp:578: {FXFONT_CHINESEBIG5_CHARSET,
FXFONT_GB2312_CHARSET,
brace-initializing a vector in an argument list is legit, right?

[Lei Zhang, 2016-04-21 22:13:10]

Still got red bots.

[Tom Sepez, 2016-04-21 22:52:14]

On 2016/04/21 22:13:10, Lei Zhang wrote:
> Still got red bots.
Green bots.

[Lei Zhang, 2016-04-21 22:57:33]

lgtm

https://codereview.chromium.org/1909213002/diff/80001/core/fpdfapi/fpdf_edit/...
File core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp (right):

https://codereview.chromium.org/1909213002/diff/80001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp:46: static const uint16_t
g_FX_CP874Unicodes[128] = {
BTW, there's a bunch of 128s in the file.

[Tom Sepez, 2016-04-21 23:05:24]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-04-21 23:05:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909213002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909213002/80001

[commit-bot: I haz the power, 2016-04-21 23:05:51]

Description was changed from

==========
Remove more CFX_ArrayTemplate from fpdf_edit_doc.cpp
==========

to

==========
Remove more CFX_ArrayTemplate from fpdf_edit_doc.cpp

Committed:
https://pdfium.googlesource.com/pdfium/+/00124c928e7513530901a3c7b0a0b928efb9...
==========

[commit-bot: I haz the power, 2016-04-21 23:05:52]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/00124c928e7513530901a3c7b0a0b928efb9...