Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1909213002: Remove more CFX_ArrayTemplate from fpdf_edit_doc.cpp (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove more CFX_ArrayTemplate from fpdf_edit_doc.cpp Committed: https://pdfium.googlesource.com/pdfium/+/00124c928e7513530901a3c7b0a0b928efb9d628

Patch Set 1 #

Patch Set 2 : stl_util.h helper even better. #

Patch Set 3 : TRUE -> true #

Patch Set 4 : Remove local charSets #

Total comments: 2

Patch Set 5 : Missing paren #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -47 lines) Patch
M core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 1 2 3 4 13 chunks +27 lines, -47 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
Tom Sepez
Lei, for review. https://codereview.chromium.org/1909213002/diff/60001/core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp File core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp (left): https://codereview.chromium.org/1909213002/diff/60001/core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp#oldcode651 core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp:651: charSets.Add(g_FX_CharsetUnicodes[i].m_Charset); Note; currently be n^2, checking ...
4 years, 8 months ago (2016-04-21 22:06:35 UTC) #2
Lei Zhang
Still got red bots.
4 years, 8 months ago (2016-04-21 22:13:10 UTC) #3
Tom Sepez
On 2016/04/21 22:13:10, Lei Zhang wrote: > Still got red bots. Green bots.
4 years, 8 months ago (2016-04-21 22:52:14 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/1909213002/diff/80001/core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp File core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp (right): https://codereview.chromium.org/1909213002/diff/80001/core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp#newcode46 core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp:46: static const uint16_t g_FX_CP874Unicodes[128] = { BTW, there's ...
4 years, 8 months ago (2016-04-21 22:57:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909213002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909213002/80001
4 years, 8 months ago (2016-04-21 23:05:34 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 23:05:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/00124c928e7513530901a3c7b0a0b928efb9...

Powered by Google App Engine
This is Rietveld 408576698