Implement arflags in the GN build.

Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of http://crrev.com/1896163003 with fix.

Committed: https://crrev.com/920a09e4e58f92bf1ece1fcf1f31ec44185a4959
Cr-Commit-Position: refs/heads/master@{#388971}

[brettw, 2016-04-21 21:04:37]

Description was changed from

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of https://codereview.chromium.org/1896163003
==========

to

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of https://codereview.chromium.org/1896163003 with fix.
==========

[brettw, 2016-04-21 21:04:38]

brettw@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brettw, 2016-04-21 21:05:15]

See delta from 1->2 for fix. Turns out the is_debug issue you noticed on the
original patch was the issue. This plugin is necessary for linking on Android
independent of other stuff.

[brettw, 2016-04-21 21:05:21]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 21:05:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909163002/20001

[commit-bot: I haz the power, 2016-04-21 21:24:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 21:24:03]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[brucedawson, 2016-04-21 21:40:27]

On 2016/04/21 21:05:15, brettw wrote:
> See delta from 1->2 for fix. Turns out the is_debug issue you noticed on the
> original patch was the issue. This plugin is necessary for linking on Android
> independent of other stuff.

Huh. Funny.

lgtm with one suggestion - the link to the original CL in the description can
cause confusion because a reader looking at this commit after it lands may
confuse that CL link with the link to this CL that will be inserted. If you
change it to crrev.com/1896163003 then it avoids that confusion. In other words,
I find it less confusing if references to other CLs in the description use a
different pattern.

[brettw, 2016-04-21 23:01:52]

Description was changed from

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of https://codereview.chromium.org/1896163003 with fix.
==========

to

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of http://crrev.com/1896163003 with fix.
==========

[brettw, 2016-04-21 23:02:03]

On 2016/04/21 21:40:27, brucedawson wrote:
> On 2016/04/21 21:05:15, brettw wrote:
> > See delta from 1->2 for fix. Turns out the is_debug issue you noticed on the
> > original patch was the issue. This plugin is necessary for linking on
Android
> > independent of other stuff.
> 
> Huh. Funny.
> 
> lgtm with one suggestion - the link to the original CL in the description can
> cause confusion because a reader looking at this commit after it lands may
> confuse that CL link with the link to this CL that will be inserted. If you
> change it to crrev.com/1896163003 then it avoids that confusion. In other
words,
> I find it less confusing if references to other CLs in the description use a
> different pattern.

OK.

[brettw, 2016-04-21 23:02:07]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-04-21 23:02:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909163002/20001

[commit-bot: I haz the power, 2016-04-22 00:23:00]

Description was changed from

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of http://crrev.com/1896163003 with fix.
==========

to

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of http://crrev.com/1896163003 with fix.
==========

[commit-bot: I haz the power, 2016-04-22 00:23:01]

Committed patchset #2 (id:20001)

[jbudorick, 2016-04-22 02:16:50]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1910393002/ by jbudorick@chromium.org.

The reason for reverting is: speculatively reverting: issues with linking on the
gpu bots again:
https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus....

[commit-bot: I haz the power, 2016-04-22 19:42:16]

Description was changed from

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of http://crrev.com/1896163003 with fix.
==========

to

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of http://crrev.com/1896163003 with fix.

Committed: https://crrev.com/920a09e4e58f92bf1ece1fcf1f31ec44185a4959
Cr-Commit-Position: refs/heads/master@{#388971}
==========

[commit-bot: I haz the power, 2016-04-22 19:42:16]

Patchset 2 (id:??) landed as
https://crrev.com/920a09e4e58f92bf1ece1fcf1f31ec44185a4959
Cr-Commit-Position: refs/heads/master@{#388971}