Chromium Code Reviews Chromium Code Reviews
Issue 1909153002:
[css-grid] Fix bug with positioned items in vertical writing mode (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html |
| index 88a45d568a5e5c7c5445f418695e910e1db1b2b4..2c38aea5f6682a0635cfbfbfb6510c0b2cdc16f8 100644 |
| --- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html |
| +++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html |
| @@ -4,11 +4,14 @@ |
| <style> |
| .grid { |
| - margin: 1px; |
| + margin: 5px; |
| width: 50px; |
| height: 25px; |
| - grid: 100% / 100%; |
| + grid: 20px / 30px; |
| padding: 5px 10px 15px 20px; |
| + border-style: solid; |
| + border-width: 5px 10px 15px 20px; |
| + float: left; |
| /* Ensures that the grid container is the containing block of the grid children. */ |
| position: relative; |
| } |
| @@ -23,19 +26,20 @@ |
| grid-row: 1 / 2; |
| } |
| +.offsets { |
| + left: 0; |
| + top: 0; |
| +} |
| + |
| .red { |
| background-color: red; |
| - width: 50px; |
| - height: 25px; |
| - top: 5px; |
| - left: 20px; |
| } |
| </style> |
| <body> |
| <p>This test checks the behavior of the positioned grid children in combination with the writing modes and text direction properties.</p> |
| -<p>For the test to pass you should see no red and all the green boxes should have the very the same position and size within each grey box. The black box will be positioned depending on the writing mode and text direction values.</p> |
| +<p>For the test to pass you should see no red and only green boxes. The black box will be positioned depending on the writing mode and text direction values.</p> |
| <div class="grid"> |
| <div class="sizedToGridArea red"></div> |
| @@ -67,5 +71,35 @@ |
| <div class="sizedToGridArea absolute onlyFirstRowOnlyFirstColumn">XX</div> |
| </div> |
| +<div class="grid"> |
| + <div class="sizedToGridArea red"></div> |
|
svillar
2016/04/22 08:17:21
Do you need all the sizedToGridArea ?
Manuel Rego
2016/04/22 08:43:56
Nope as it stretches by default, I've just removed
|
| + <div class="sizedToGridArea absolute offsets onlyFirstRowOnlyFirstColumn">XX</div> |
| +</div> |
| + |
| +<div class="grid verticalRL"> |
| + <div class="sizedToGridArea red"></div> |
| + <div class="sizedToGridArea absolute offsets onlyFirstRowOnlyFirstColumn">XX</div> |
| +</div> |
| + |
| +<div class="grid verticalLR"> |
| + <div class="sizedToGridArea red"></div> |
| + <div class="sizedToGridArea absolute offsets onlyFirstRowOnlyFirstColumn">XX</div> |
| +</div> |
| + |
| +<div class="grid directionRTL"> |
| + <div class="sizedToGridArea red"></div> |
| + <div class="sizedToGridArea absolute offsets onlyFirstRowOnlyFirstColumn">XX</div> |
| +</div> |
| + |
| +<div class="grid verticalRL directionRTL"> |
| + <div class="sizedToGridArea red"></div> |
| + <div class="sizedToGridArea absolute offsets onlyFirstRowOnlyFirstColumn">XX</div> |
| +</div> |
| + |
| +<div class="grid verticalLR directionRTL"> |
| + <div class="sizedToGridArea red"></div> |
| + <div class="sizedToGridArea absolute offsets onlyFirstRowOnlyFirstColumn">XX</div> |
| +</div> |
| + |
| </body> |
| </html> |
