blimp/net/blimp_message_output_buffer.h - Issue 1909143002: Use ConnectionErrorObserver, not callbacks, for error handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/net/blimp_message_output_buffer.h

Issue 1909143002: Use ConnectionErrorObserver, not callbacks, for error handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wez feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/net/blimp_message_output_buffer.h

diff --git a/blimp/net/blimp_message_output_buffer.h b/blimp/net/blimp_message_output_buffer.h

index bc5bd6015f387e7453f17f4f715f63bd0f15251b..701d787c9143c09eae3ab6c2b7eea60f42ffa272 100644

--- a/blimp/net/blimp_message_output_buffer.h

+++ b/blimp/net/blimp_message_output_buffer.h

@@ -71,7 +71,7 @@ class BLIMP_NET_EXPORT BlimpMessageOutputBuffer

// and the buffer contains a message.

void WriteNextMessageIfReady();

- // Receives the completion status of a write operation.

+ // Called after a successful write.

void OnWriteComplete(int result);

BlimpMessageProcessor* output_processor_ = nullptr;

« blimp/net/blimp_connection.cc ('K') | « blimp/net/blimp_connection_unittest.cc ('k') | blimp/net/blimp_message_output_buffer.cc » ('j') | blimp/net/blimp_message_output_buffer.cc » ('J')