blimp/net/blimp_connection_unittest.cc - Issue 1909143002: Use ConnectionErrorObserver, not callbacks, for error handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/net/blimp_connection_unittest.cc

Issue 1909143002: Use ConnectionErrorObserver, not callbacks, for error handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/net/blimp_connection_unittest.cc

diff --git a/blimp/net/blimp_connection_unittest.cc b/blimp/net/blimp_connection_unittest.cc

index 59c7a39a370f218e2a17c58283f87dd14d19822b..5f22ba154bb3fddeb843e56f89e448f0055f03c2 100644

--- a/blimp/net/blimp_connection_unittest.cc

+++ b/blimp/net/blimp_connection_unittest.cc

@@ -132,7 +132,6 @@ TEST_F(BlimpConnectionTest, AsyncTwoPacketsWriteWithError) {

sender->ProcessMessage(CreateControlMessage(),

complete_cb_2.callback());

base::ResetAndReturn(&write_packet_cb).Run(net::ERR_FAILED);

- EXPECT_EQ(net::ERR_FAILED, complete_cb_2.WaitForResult());

Wez 2016/04/21 22:44:29 Can we assert that the second callback has not bee

Kevin M 2016/04/22 22:10:41 Done.

}

} // namespace

« blimp/net/blimp_connection.cc ('K') | « blimp/net/blimp_connection.cc ('k') | blimp/net/blimp_message_output_buffer.cc » ('j') | blimp/net/blimp_message_output_buffer.cc » ('J')