Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
190913003:
Get rid of unnecessary layouts on body elements with quirky children (Closed)
|
Created:
6 years, 9 months ago by rhogan Modified:
6 years, 9 months ago Reviewers:
ojan CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr. Base URL:
svn://svn.chromium.org/blink/trunk Visibility:
Public. |
DescriptionGet rid of unnecessary layouts on body elements with quirky children
RenderBlockFlow::marginBeforeEstimateForChild() was checking the wrong
margin when detecting quirky children. The performance test added by
this patch times out without the change in this CL - obviously a
pathological case!
BUG=
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169269
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169790
Patch Set 1 #Patch Set 2 : Removed Test #Messages
Total messages: 23 (0 generated)
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/190913003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on mac_blink_compile
The CQ bit was checked by robhogan@gmail.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/190913003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on mac_blink_rel
The CQ bit was checked by robhogan@gmail.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/190913003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on mac_blink_rel
The CQ bit was checked by robhogan@gmail.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/190913003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on mac_blink_rel
The CQ bit was checked by robhogan@gmail.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/190913003/1
Message was sent while issue was closed.
Change committed as 169269
The CQ bit was checked by robhogan@gmail.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/190913003/20001
Message was sent while issue was closed.
Change committed as 169790 |
