Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: remoting/host/logging_posix.cc

Issue 19091004: Only use the LoggingLock when actually logging to a file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/logging.cc ('k') | remoting/host/logging_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/host/logging.h" 5 #include "remoting/host/logging.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace remoting { 9 namespace remoting {
10 10
11 void InitHostLogging() { 11 void InitHostLogging() {
12 // Write logs to the system debug log. 12 // Write logs to the system debug log.
13 logging::LoggingSettings settings; 13 logging::LoggingSettings settings;
14 settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG; 14 settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;
15 // TODO(alexeypa): remove this line once logging is updated to not create
16 // the lock if the log file is not used.
17 settings.lock_log = logging::DONT_LOCK_LOG_FILE;
18 logging::InitLogging(settings); 15 logging::InitLogging(settings);
19 } 16 }
20 17
21 } // namespace remoting 18 } // namespace remoting
OLDNEW
« no previous file with comments | « base/logging.cc ('k') | remoting/host/logging_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698