Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: remoting/host/logging_win.cc

Issue 19091004: Only use the LoggingLock when actually logging to a file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« base/logging.cc ('K') | « remoting/host/logging_posix.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/host/logging.h" 5 #include "remoting/host/logging.h"
6 6
7 #include <guiddef.h> 7 #include <guiddef.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/logging_win.h" 10 #include "base/logging_win.h"
11 11
12 // {2db51ca1-4fd8-4b88-b5a2-fb8606b66b02} 12 // {2db51ca1-4fd8-4b88-b5a2-fb8606b66b02}
13 const GUID kRemotingHostLogProvider = 13 const GUID kRemotingHostLogProvider =
14 { 0x2db51ca1, 0x4fd8, 0x4b88, 14 { 0x2db51ca1, 0x4fd8, 0x4b88,
15 { 0xb5, 0xa2, 0xfb, 0x86, 0x06, 0xb6, 0x6b, 0x02 } }; 15 { 0xb5, 0xa2, 0xfb, 0x86, 0x06, 0xb6, 0x6b, 0x02 } };
16 16
17 namespace remoting { 17 namespace remoting {
18 18
19 void InitHostLogging() { 19 void InitHostLogging() {
20 // Write logs to the system debug log. 20 // Write logs to the system debug log.
21 logging::LoggingSettings settings; 21 logging::LoggingSettings settings;
22 settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG; 22 settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;
23 // TODO(alexeypa): remove this line once logging is updated to not create
24 // the lock if the log file is not used.
25 settings.lock_log = logging::DONT_LOCK_LOG_FILE;
26 logging::InitLogging(settings); 23 logging::InitLogging(settings);
27 24
28 // Enable trace control and transport through event tracing for Windows. 25 // Enable trace control and transport through event tracing for Windows.
29 logging::LogEventProvider::Initialize(kRemotingHostLogProvider); 26 logging::LogEventProvider::Initialize(kRemotingHostLogProvider);
30 } 27 }
31 28
32 } // namespace remoting 29 } // namespace remoting
OLDNEW
« base/logging.cc ('K') | « remoting/host/logging_posix.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698