Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1909083002: Add modules.dll.pdb to chrome.isolate for better stack traces on bots. (Closed)

Created:
4 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 8 months ago
Reviewers:
David Yen, M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add modules.dll.pdb to chrome.isolate for better stack traces on bots. BUG=605637 Committed: https://crrev.com/137b3af03190d36bb6a0b7079f54cb0b924cc743 Cr-Commit-Position: refs/heads/master@{#388869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/chrome.isolate View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Ken Russell (switch to Gerrit)
dyen or maruel: please review and CQ. Thanks.
4 years, 8 months ago (2016-04-21 18:07:35 UTC) #2
M-A Ruel
lgtm
4 years, 8 months ago (2016-04-21 18:07:55 UTC) #3
David Yen
nit: Git description has wrong name in title. On another note, how is the modules.dll ...
4 years, 8 months ago (2016-04-21 18:10:57 UTC) #4
Ken Russell (switch to Gerrit)
On 2016/04/21 18:10:57, David Yen wrote: > nit: Git description has wrong name in title. ...
4 years, 8 months ago (2016-04-21 18:47:58 UTC) #6
Ken Russell (switch to Gerrit)
On 2016/04/21 18:47:58, Ken Russell wrote: > On 2016/04/21 18:10:57, David Yen wrote: > > ...
4 years, 8 months ago (2016-04-21 18:48:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909083002/1
4 years, 8 months ago (2016-04-21 18:49:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 20:03:18 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:38:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/137b3af03190d36bb6a0b7079f54cb0b924cc743
Cr-Commit-Position: refs/heads/master@{#388869}

Powered by Google App Engine
This is Rietveld 408576698