Add modules.dll.pdb to chrome.isolate for better stack traces on bots.

Add modules.dll.pdb to chrome.isolate for better stack traces on bots.

BUG=605637
Committed: https://crrev.com/137b3af03190d36bb6a0b7079f54cb0b924cc743
Cr-Commit-Position: refs/heads/master@{#388869}

[Ken Russell (switch to Gerrit), 2016-04-21 18:07:34]

kbr@chromium.org changed reviewers:
+ dyen@chromium.org, maruel@chromium.org

[Ken Russell (switch to Gerrit), 2016-04-21 18:07:35]

dyen or maruel: please review and CQ. Thanks.

[M-A Ruel, 2016-04-21 18:07:55]

lgtm

[David Yen, 2016-04-21 18:10:57]

nit: Git description has wrong name in title.

On another note, how is the modules.dll even included in the isolate? I don't
see any reference to it.

[Ken Russell (switch to Gerrit), 2016-04-21 18:47:35]

Description was changed from

==========
Add modules.pdb.dll to chrome.isolate for better stack traces on bots.

BUG=605637
==========

to

==========
Add modules.dll.pdb to chrome.isolate for better stack traces on bots.

BUG=605637
==========

[Ken Russell (switch to Gerrit), 2016-04-21 18:47:58]

On 2016/04/21 18:10:57, David Yen wrote:
> nit: Git description has wrong name in title.
> 
> On another note, how is the modules.dll even included in the isolate? I don't
> see any reference to it.

It's built via the component build. In the statically linked build it doesn't
exist.

[Ken Russell (switch to Gerrit), 2016-04-21 18:48:13]

On 2016/04/21 18:47:58, Ken Russell wrote:
> On 2016/04/21 18:10:57, David Yen wrote:
> > nit: Git description has wrong name in title.
> > 
> > On another note, how is the modules.dll even included in the isolate? I
don't
> > see any reference to it.
> 
> It's built via the component build. In the statically linked build it doesn't
> exist.

Also: corrected the CL description.

[Ken Russell (switch to Gerrit), 2016-04-21 18:48:17]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-04-21 18:49:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909083002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909083002/1

[commit-bot: I haz the power, 2016-04-21 20:03:18]

Description was changed from

==========
Add modules.dll.pdb to chrome.isolate for better stack traces on bots.

BUG=605637
==========

to

==========
Add modules.dll.pdb to chrome.isolate for better stack traces on bots.

BUG=605637
==========

[commit-bot: I haz the power, 2016-04-21 20:03:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-22 19:38:20]

Description was changed from

==========
Add modules.dll.pdb to chrome.isolate for better stack traces on bots.

BUG=605637
==========

to

==========
Add modules.dll.pdb to chrome.isolate for better stack traces on bots.

BUG=605637

Committed: https://crrev.com/137b3af03190d36bb6a0b7079f54cb0b924cc743
Cr-Commit-Position: refs/heads/master@{#388869}
==========

[commit-bot: I haz the power, 2016-04-22 19:38:21]

Patchset 1 (id:??) landed as
https://crrev.com/137b3af03190d36bb6a0b7079f54cb0b924cc743
Cr-Commit-Position: refs/heads/master@{#388869}