Add UMA metrics for multi-window mode and multi-instance

Add UMA metrics for multi-window mode and multi-instance

 Record actions when the activity enters/exits Android N
 multi-window mode and when a second activity instance
 is created. Also record histograms for the screen width
 when in multi-window mode on tablets.

 BUG=595157
Committed: https://crrev.com/c8f92403f725aff39969e477a0c7ddf0b3aa9a65
Cr-Commit-Position: refs/heads/master@{#389525}

[Theresa, 2016-04-21 16:54:25]

twellington@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Theresa, 2016-04-21 16:54:26]

ptal

[Ted C, 2016-04-22 20:58:57]

https://codereview.chromium.org/1909043002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/1909043002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1346:
mHandler.postDelayed(mRecordMultiWindowModeScreenWidthRunnable,
should this be inside the if check above?  otherwise, we are going to log this
everytime the user brings up the keyboard and stuff right?

https://codereview.chromium.org/1909043002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity2.java
(right):

https://codereview.chromium.org/1909043002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity2.java:28:
RecordUserAction.record("Android.MultiWindowMode.MultiInstance.Enter");
Is this guaranteed to be true?  What happens if you fullscreen the second
instance and come back to it, will this trigger a multi-instance enter call?

Why wouldn't onDeferredStartup be called on this class?  "Seems" like it should
be called as often as it is on the base class.

[Theresa, 2016-04-22 22:44:29]

https://codereview.chromium.org/1909043002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/1909043002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1346:
mHandler.postDelayed(mRecordMultiWindowModeScreenWidthRunnable,
On 2016/04/22 20:58:56, Ted C wrote:
> should this be inside the if check above?  otherwise, we are going to log this
> everytime the user brings up the keyboard and stuff right?

Yes, it should.

https://codereview.chromium.org/1909043002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity2.java
(right):

https://codereview.chromium.org/1909043002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity2.java:28:
RecordUserAction.record("Android.MultiWindowMode.MultiInstance.Enter");
On 2016/04/22 20:58:56, Ted C wrote:
> Is this guaranteed to be true?  What happens if you fullscreen the second
> instance and come back to it, will this trigger a multi-instance enter call?
> 
> Why wouldn't onDeferredStartup be called on this class?  "Seems" like it
should
> be called as often as it is on the base class.

The mRecordedCreation boolean guarded against logging again when fullscreening
the second instance and coming back tp it.

Changed this logging to happen in onDeferredStartupForMultiWindowMode() and am
now calling postDeferredStartupIfNeeded() from
ChromeActivity#onStartWithNative() if the activity tab isn't loading. We start
loading the tabs before onStartWithNative() gets called so tab.isLoading()
returns true if a load is still in progress.

[Ted C, 2016-04-22 22:58:14]

lgtm

[Theresa, 2016-04-22 22:59:05]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2016-04-22 22:59:06]

The CQ bit was unchecked by twellington@chromium.org

[Theresa, 2016-04-22 22:59:37]

twellington@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Theresa, 2016-04-22 22:59:38]

+rkaplow@ - ptal at actions.xml and histograms.xml

[rkaplow, 2016-04-25 15:24:59]

lgtm

[Theresa, 2016-04-25 17:17:10]

The CQ bit was checked by twellington@chromium.org

[commit-bot: I haz the power, 2016-04-25 17:17:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909043002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909043002/20001

[commit-bot: I haz the power, 2016-04-25 17:29:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 17:29:20]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Theresa, 2016-04-25 18:35:46]

The CQ bit was checked by twellington@chromium.org

[commit-bot: I haz the power, 2016-04-25 18:36:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909043002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909043002/20001

[commit-bot: I haz the power, 2016-04-25 18:42:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-25 18:45:07]

Description was changed from

==========
Add UMA metrics for multi-window mode and multi-instance

 Record actions when the activity enters/exits Android N
 multi-window mode and when a second activity instance
 is created. Also record histograms for the screen width
 when in multi-window mode on tablets.

 BUG=595157
==========

to

==========
Add UMA metrics for multi-window mode and multi-instance

 Record actions when the activity enters/exits Android N
 multi-window mode and when a second activity instance
 is created. Also record histograms for the screen width
 when in multi-window mode on tablets.

 BUG=595157

Committed: https://crrev.com/c8f92403f725aff39969e477a0c7ddf0b3aa9a65
Cr-Commit-Position: refs/heads/master@{#389525}
==========

[commit-bot: I haz the power, 2016-04-25 18:45:08]

Patchset 2 (id:??) landed as
https://crrev.com/c8f92403f725aff39969e477a0c7ddf0b3aa9a65
Cr-Commit-Position: refs/heads/master@{#389525}