third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 1909033003: Add FrameView::updateAllLifecyclePhasesExceptPaint and use it in a few cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1909033003: Add FrameView::updateAllLifecyclePhasesExceptPaint and use it in a few cases. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 83e913c1cda36c0faedecbcbe96c51febe5a3975..7b9c1c85810ff418f51caa4ac8d11a0c0ed69a79 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -303,8 +303,7 @@ public:

if (!frame()->document() || !frame()->document()->layoutView())

return 0;

- // TODO(crbug.com/603230): Synchronized painting is unnecessary in this lifecycle update.

- frame()->view()->updateAllLifecyclePhases();

+ frame()->view()->updateAllLifecyclePhasesExceptPaint();

if (!frame()->document() || !frame()->document()->layoutView())

return 0;

@@ -323,8 +322,7 @@ public:

if (!frame()->document() || !frame()->document()->layoutView())

return;

- // TODO(crbug.com/603230): Synchronized painting is unnecessary in this lifecycle update.

- frame()->view()->updateAllLifecyclePhases();

+ frame()->view()->updateAllLifecyclePhasesExceptPaint();

if (!frame()->document() || !frame()->document()->layoutView())

return;

« no previous file with comments | « third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp ('k') | no next file » | no next file with comments »