third_party/WebKit/Source/core/frame/LocalFrame.cpp - Issue 1909033003: Add FrameView::updateAllLifecyclePhasesExceptPaint and use it in a few cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 1909033003: Add FrameView::updateAllLifecyclePhasesExceptPaint and use it in a few cases. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

index 6924697b51535ba80bc7ecfe94199a1935e12238..8cf5554a4a9adc8998ca266b39b3acad6225e10a 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

@@ -619,8 +619,7 @@ double LocalFrame::devicePixelRatio() const

PassOwnPtr<DragImage> LocalFrame::nodeImage(Node& node)

{

- // TODO(crbug.com/603230): Synchronized painting is unnecessary in this lifecycle update.

- m_view->updateAllLifecyclePhases();

+ m_view->updateAllLifecyclePhasesExceptPaint();

LayoutObject* layoutObject = node.layoutObject();

if (!layoutObject)

return nullptr;

@@ -646,8 +645,7 @@ PassOwnPtr<DragImage> LocalFrame::dragImageForSelection(float opacity)

if (!selection().isRange())

return nullptr;

- // TODO(crbug.com/603230): Synchronized painting is unnecessary in the lifecycle update.

- m_view->updateAllLifecyclePhases();

+ m_view->updateAllLifecyclePhasesExceptPaint();

ASSERT(document()->isActive());

FloatRect paintingRect = FloatRect(selection().bounds());