Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1607)

Issue 1908983002: headless: Switch to multiprocess mode by default (Closed)

Created:
4 years, 8 months ago by Sami
Modified:
4 years, 8 months ago
Reviewers:
Mike West, altimin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Switch to multiprocess mode by default Switch the headless library to multiprocess mode by default so sandbox isolation is used by default. BUG=546953 Committed: https://crrev.com/1ca0345a9771f9b75d826e14cfde75f9822081f3 Cr-Commit-Position: refs/heads/master@{#389523}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M headless/lib/headless_content_main_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M headless/public/headless_browser.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M headless/public/headless_browser.cc View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Sami
Hey Mike, do you think the text above this setting is worded sternly enough?-)
4 years, 8 months ago (2016-04-21 13:20:51 UTC) #3
Sami
4 years, 8 months ago (2016-04-25 14:17:14 UTC) #5
Mike West
LGTM. I don't think it's any worse than the single-process flag we already have, so, ...
4 years, 8 months ago (2016-04-25 14:20:43 UTC) #6
altimin
lgtm
4 years, 8 months ago (2016-04-25 14:21:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908983002/20001
4 years, 8 months ago (2016-04-25 17:51:52 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 18:38:36 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 18:40:01 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1ca0345a9771f9b75d826e14cfde75f9822081f3
Cr-Commit-Position: refs/heads/master@{#389523}

Powered by Google App Engine
This is Rietveld 408576698