Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1908973002: [NTP Snippets] Add newly-fetched snippets at the front instead of at the end (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, mcwilliams+watch_chromium.org, dgn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Add newly-fetched snippets at the front instead of at the end BUG=601736 Committed: https://crrev.com/dd5aacea530b6a32cb3fdf358093a091d600d08e Cr-Commit-Position: refs/heads/master@{#389057}

Patch Set 1 #

Total comments: 2

Patch Set 2 : spaces! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -28 lines) Patch
M components/ntp_snippets/ntp_snippets_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 5 chunks +26 lines, -25 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service_unittest.cc View 1 2 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908973002/1
4 years, 8 months ago (2016-04-21 13:09:46 UTC) #2
Marc Treib
PTAL!
4 years, 8 months ago (2016-04-21 13:09:50 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-21 13:56:24 UTC) #6
Bernhard Bauer
LGTM https://codereview.chromium.org/1908973002/diff/1/components/ntp_snippets/ntp_snippets_service_unittest.cc File components/ntp_snippets/ntp_snippets_service_unittest.cc (right): https://codereview.chromium.org/1908973002/diff/1/components/ntp_snippets/ntp_snippets_service_unittest.cc#newcode242 components/ntp_snippets/ntp_snippets_service_unittest.cc:242: "{ \"contentInfo\": { \"url\" : \"http://first\" }}" Maybe ...
4 years, 8 months ago (2016-04-21 16:21:28 UTC) #7
Marc Treib
https://codereview.chromium.org/1908973002/diff/1/components/ntp_snippets/ntp_snippets_service_unittest.cc File components/ntp_snippets/ntp_snippets_service_unittest.cc (right): https://codereview.chromium.org/1908973002/diff/1/components/ntp_snippets/ntp_snippets_service_unittest.cc#newcode242 components/ntp_snippets/ntp_snippets_service_unittest.cc:242: "{ \"contentInfo\": { \"url\" : \"http://first\" }}" On 2016/04/21 ...
4 years, 8 months ago (2016-04-22 08:16:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908973002/20001
4 years, 8 months ago (2016-04-22 08:25:37 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 09:06:56 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:45:33 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/dd5aacea530b6a32cb3fdf358093a091d600d08e
Cr-Commit-Position: refs/heads/master@{#389057}

Powered by Google App Engine
This is Rietveld 408576698